From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45555)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1R6MBW-0000dN-FQ
	for qemu-devel@nongnu.org; Wed, 21 Sep 2011 08:45:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1R6MBP-0002Fy-S2
	for qemu-devel@nongnu.org; Wed, 21 Sep 2011 08:45:54 -0400
Received: from mail-yi0-f45.google.com ([209.85.218.45]:33845)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1R6MBP-0002Fq-PM
	for qemu-devel@nongnu.org; Wed, 21 Sep 2011 08:45:47 -0400
Received: by yib2 with SMTP id 2so1384222yib.4
	for <qemu-devel@nongnu.org>; Wed, 21 Sep 2011 05:45:47 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1315838844-14307-2-git-send-email-devin122@gmail.com>
References: <1315838844-14307-1-git-send-email-devin122@gmail.com>
	<1315838844-14307-2-git-send-email-devin122@gmail.com>
Date: Wed, 21 Sep 2011 13:45:47 +0100
Message-ID: <CAJSP0QUDCnH08e7sA15ZeAkXEUY9cwuGKnPiWUo9LYYow9EEFA@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/6] qed: add qed_find_cluster_sync()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Devin Nakamura <devin122@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

On Mon, Sep 12, 2011 at 3:47 PM, Devin Nakamura <devin122@gmail.com> wrote:
/* See qed_find_cluster(), especially how request->l2_table reference
count works */
> +int qed_find_cluster_sync(BDRVQEDState *s, QEDRequest *request, uint64_t=
 pos,
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0size_t len, uint64_t=
 *offset,
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0size_t *contiguous_b=
ytes)

If you respin please add a comment like the one above.  It's easy to
forget that this function grabs the l2_table and gives you a
reference.  Let's put a warning in place.

Stefan