From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34765)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bHYyV-0007Dq-Lx
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 12:01:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bHYyT-0004kP-Oy
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 12:01:26 -0400
Received: from mail-vk0-x242.google.com ([2607:f8b0:400c:c05::242]:33556)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bHYyT-0004kL-Kr
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 12:01:25 -0400
Received: by mail-vk0-x242.google.com with SMTP id v190so2238608vka.0
	for <qemu-devel@nongnu.org>; Mon, 27 Jun 2016 09:01:25 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1466775608-31052-1-git-send-email-roman.penyaev@profitbricks.com>
References: <1466775608-31052-1-git-send-email-roman.penyaev@profitbricks.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Date: Mon, 27 Jun 2016 17:01:24 +0100
Message-ID: <CAJSP0QUGMYsW-v9emTfaV8zuLEG2NuX_axyOFKvSw0K1j4pACg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 1/1] Revert "linux-aio: Cancel BH if not
 needed"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Roman Pen <roman.penyaev@profitbricks.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On Fri, Jun 24, 2016 at 2:40 PM, Roman Pen
<roman.penyaev@profitbricks.com> wrote:
> diff --git a/block/linux-aio.c b/block/linux-aio.c
> index e468960..fe7cece 100644
> --- a/block/linux-aio.c
> +++ b/block/linux-aio.c
> @@ -149,8 +149,6 @@ static void qemu_laio_completion_bh(void *opaque)
>      if (!s->io_q.plugged && !QSIMPLEQ_EMPTY(&s->io_q.pending)) {
>          ioq_submit(s);
>      }
> -
> -    qemu_bh_cancel(s->completion_bh);

This was the cause.  I've found the root cause and will send a patch.

Stefan