From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.1] monitor: Fix memory leak with readline completion
Date: Mon, 11 Jun 2012 13:19:37 +0100 [thread overview]
Message-ID: <CAJSP0QUO2_57KwfM2m=j4_UeGLQM8-Qcbaru18wKTpMFCWtxTg@mail.gmail.com> (raw)
In-Reply-To: <1337024840-28273-1-git-send-email-sw@weilnetz.de>
On Mon, May 14, 2012 at 8:47 PM, Stefan Weil <sw@weilnetz.de> wrote:
> Each string which is shown during readline completion in the QEMU monitor
> is allocated dynamically but currently never deallocated.
>
> Add the missing loop which calls g_free for the allocated strings.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> readline.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
prev parent reply other threads:[~2012-06-11 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 19:47 [Qemu-devel] [PATCH 1.1] monitor: Fix memory leak with readline completion Stefan Weil
2012-05-22 20:24 ` Stefan Weil
2012-06-09 21:36 ` Stefan Weil
2012-06-12 19:42 ` Luiz Capitulino
2012-06-11 12:19 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJSP0QUO2_57KwfM2m=j4_UeGLQM8-Qcbaru18wKTpMFCWtxTg@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).