From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
Alberto Garcia <berto@igalia.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling
Date: Mon, 23 Mar 2015 15:00:05 +0000 [thread overview]
Message-ID: <CAJSP0QUOTra0shpnuo1jrRebdVfnt2cpnpT2EGaCsPxY6iat2A@mail.gmail.com> (raw)
In-Reply-To: <55102804.20808@redhat.com>
On Mon, Mar 23, 2015 at 2:49 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 23/03/2015 15:28, Stefan Hajnoczi wrote:
>> I'd like to know what problems exactly this patch fixes. The test
>> case for throttling actually relies on the virtual clock so it can be
>> stepped deterministically. What other legitimate cases are there
>> where throttling is used outside a running qemu-system process?
>
> Alberto brought up block jobs. It is debatable whether block jobs
> should be stopped while the VM is.
This patch is unrelated to block jobs. Block jobs use their own
ratelimiting mechanism and the realtime clock (not vm clock).
Stefan
next prev parent reply other threads:[~2015-03-23 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 5:24 [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling Fam Zheng
2015-03-23 8:10 ` Paolo Bonzini
2015-03-23 8:56 ` Alberto Garcia
2015-03-23 13:56 ` Stefan Hajnoczi
2015-03-23 13:58 ` Paolo Bonzini
2015-03-23 14:28 ` Stefan Hajnoczi
2015-03-23 14:49 ` Paolo Bonzini
2015-03-23 15:00 ` Stefan Hajnoczi [this message]
2015-03-23 15:02 ` Paolo Bonzini
2015-03-24 1:17 ` Fam Zheng
2015-03-24 13:29 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QUOTra0shpnuo1jrRebdVfnt2cpnpT2EGaCsPxY6iat2A@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=berto@igalia.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).