From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>,
Liu Yuan <namei.unix@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
qemu block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] sheepdog: remove back pointer to BlockDriverState
Date: Mon, 3 Aug 2015 13:48:59 +0100 [thread overview]
Message-ID: <CAJSP0QURzDX1zD67osdtm6F-OC_b5OmOgVLP31s0SLTtK2H5JA@mail.gmail.com> (raw)
In-Reply-To: <1438595557-28144-1-git-send-email-pbonzini@redhat.com>
On Mon, Aug 3, 2015 at 10:52 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Since sheepdog does not implement a rebind callback, this back pointer
> is dangerous. Do not use it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/sheepdog.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
prev parent reply other threads:[~2015-08-03 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 9:52 [Qemu-devel] [PATCH] sheepdog: remove back pointer to BlockDriverState Paolo Bonzini
2015-08-03 12:40 ` Jeff Cody
2015-08-03 12:44 ` Paolo Bonzini
2015-08-03 12:48 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QURzDX1zD67osdtm6F-OC_b5OmOgVLP31s0SLTtK2H5JA@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=mitake.hitoshi@lab.ntt.co.jp \
--cc=namei.unix@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).