From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: preserve free_byte_offset when qcow2_alloc_bytes() fails
Date: Mon, 18 Jun 2012 14:16:38 +0100 [thread overview]
Message-ID: <CAJSP0QUSpvS5vN8xcDPROzAP5apb_E1rievYEEegrfYH2R9YJQ@mail.gmail.com> (raw)
In-Reply-To: <4FDF28FB.7090701@redhat.com>
On Mon, Jun 18, 2012 at 2:11 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 18.06.2012 15:00, schrieb Stefan Hajnoczi:
>> When qcow2_alloc_clusters() error handling code was introduced in commit
>> 5d757b563d59142ca81e1073a8e8396750a0ad1a, the value of free_byte_offset
>> was clobbered in the error case. This patch keeps free_byte_offset at 0
>> so we will try to allocate clusters again next time this function is
>> called.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>
> Thanks, applied to the block branch.
>
> And I guess we should get test case 026 fixed up and extended to cover this.
I'm not sure what to test. It already returned the error code
correctly. The problem was what happened when called again - there
would be junk in free_byte_offset.
Stefan
next prev parent reply other threads:[~2012-06-18 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 13:00 [Qemu-devel] [PATCH] qcow2: preserve free_byte_offset when qcow2_alloc_bytes() fails Stefan Hajnoczi
2012-06-18 13:11 ` Kevin Wolf
2012-06-18 13:16 ` Stefan Hajnoczi [this message]
2012-06-18 13:29 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QUSpvS5vN8xcDPROzAP5apb_E1rievYEEegrfYH2R9YJQ@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).