From: Stefan Hajnoczi <stefanha@gmail.com>
To: Alexander Graf <graf@amazon.com>
Cc: qemu-devel@nongnu.org, David Hildenbrand <david@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
"Daniel P . Berrange" <berrange@redhat.com>,
Eric Blake <eblake@redhat.com>,
Philippe Mathieu-Daude <philmd@linaro.org>,
Peter Xu <peterx@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v2] hostmem-file: add offset option
Date: Sat, 1 Apr 2023 08:18:07 -0400 [thread overview]
Message-ID: <CAJSP0QUTN6Jp5go=_j_6F14mxs0=4pdfTGmcVyedMJo3YELYOw@mail.gmail.com> (raw)
In-Reply-To: <20230401121316.2025-1-graf@amazon.com>
On Sat, 1 Apr 2023 at 08:14, Alexander Graf <graf@amazon.com> wrote:
> diff --git a/qapi/qom.json b/qapi/qom.json
> index a877b879b9..8f5eaa8415 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -635,6 +635,10 @@
> # specify the required alignment via this option.
> # 0 selects a default alignment (currently the page size). (default: 0)
> #
> +# @offset: the offset into the target file that the region starts at. You can
> +# use this option to overload multiple regions into a single fils.
s/fils/file/
Other than that:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2023-04-01 12:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 12:13 [PATCH v2] hostmem-file: add offset option Alexander Graf
2023-04-01 12:18 ` Stefan Hajnoczi [this message]
2023-04-03 6:28 ` Markus Armbruster
2023-04-03 19:50 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJSP0QUTN6Jp5go=_j_6F14mxs0=4pdfTGmcVyedMJo3YELYOw@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=ashish.kalra@amd.com \
--cc=berrange@redhat.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=graf@amazon.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).