From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55077)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RlH2Z-0002W6-3r
	for qemu-devel@nongnu.org; Thu, 12 Jan 2012 04:33:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RlH2S-0002lV-Di
	for qemu-devel@nongnu.org; Thu, 12 Jan 2012 04:33:47 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:39052)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RlH2S-0002lK-Ac
	for qemu-devel@nongnu.org; Thu, 12 Jan 2012 04:33:40 -0500
Received: by iaeo4 with SMTP id o4so1140985iae.4
	for <qemu-devel@nongnu.org>; Thu, 12 Jan 2012 01:33:38 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <87vcojrx20.fsf@ginnungagap.bsc.es>
References: <1326193179-19677-1-git-send-email-harsh@linux.vnet.ibm.com>
	<1326193179-19677-2-git-send-email-harsh@linux.vnet.ibm.com>
	<87vcojrx20.fsf@ginnungagap.bsc.es>
Date: Thu, 12 Jan 2012 09:33:38 +0000
Message-ID: <CAJSP0QUTVb9GS9=xmHM1yebW+d0Ya-AYjf63A8RF5xv1TdXALw@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to
	tracetool.py
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Llu=EDs_Vilanova?= <vilanova@ac.upc.edu>
Cc: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>, aneesh.kumar@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org

2012/1/10 Llu=EDs Vilanova <vilanova@ac.upc.edu>:
> Harsh Prateek Bora writes:
>> +class Event(object):
>> + =A0 =A0def __init__(self, num, line):
>> + =A0 =A0 =A0 =A0self.num =3D num
>> + =A0 =A0 =A0 =A0self.args =3D get_args(line)
>> + =A0 =A0 =A0 =A0self.arglist =3D self.args.split(',')
>> + =A0 =A0 =A0 =A0self.name =3D get_name(line)
>> + =A0 =A0 =A0 =A0self.argc =3D get_argc(line)
>> + =A0 =A0 =A0 =A0self.argnames =3D get_argnames(line)
>> + =A0 =A0 =A0 =A0self.sizestr =3D calc_sizeofargs(line)
>> + =A0 =A0 =A0 =A0self.fmt =3D get_fmt(line)
>
> This is not not extracting the event properties (e.g., disable). A set of
> strings should suffice.
>
> Arguments could be converted to an Arguments class (or similar, like
> ArgumentList) and derive the rest from there using methods (e.g., names, =
types,
> sizestr, arglist, etc.).

Yes, that would be nice.  This will separate the trace-events parsing
from the rest of the program, which can use the Event/Argument
interface instead of parsing strings.

Stefan