qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: Kevin Wolf <kwolf@redhat.com>,
	benoit.canet@gmail.com, qemu-devel@nongnu.org,
	stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 3/3] migration: block migration when streaming block jobs are running.
Date: Mon, 23 Jul 2012 11:43:54 +0100	[thread overview]
Message-ID: <CAJSP0QUUazd41x2xpPyWs8HArRaizmCAdDHDX4b_S5kASZxiOw@mail.gmail.com> (raw)
In-Reply-To: <20120723101734.GA19871@irqsave.net>

On Mon, Jul 23, 2012 at 11:17 AM, Benoît Canet <benoit.canet@irqsave.net> wrote:
> Would
>
> int bdrv_are_busy(void)
> {
>     BlockDriverState *bs;
>
>     QTAILQ_FOREACH(bs, &bdrv_states, list) {
>         if (bs->job || bdrv_in_use(bs)) {
>             return -EBUSY;
>         }
>     }
>
>     return 0;
> }
>
> be more acceptable ?

Looks fine to me.

Stefan

      reply	other threads:[~2012-07-23 10:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20 19:32 [Qemu-devel] [PATCH 0/3] Block migration when streaming block jobs are running benoit.canet
2012-07-20 19:32 ` [Qemu-devel] [PATCH 1/3] block: Add bdrv_have_block_jobs() so migration code abort if needed benoit.canet
2012-07-23 10:02   ` Paolo Bonzini
2012-07-23 10:25     ` Benoît Canet
2012-07-20 19:32 ` [Qemu-devel] [PATCH 2/3] qerror: Add error telling that streaming blocks migration benoit.canet
2012-07-20 19:32 ` [Qemu-devel] [PATCH 3/3] migration: block migration when streaming block jobs are running benoit.canet
2012-07-23  9:55   ` Stefan Hajnoczi
2012-07-23 10:17     ` Benoît Canet
2012-07-23 10:43       ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJSP0QUUazd41x2xpPyWs8HArRaizmCAdDHDX4b_S5kASZxiOw@mail.gmail.com \
    --to=stefanha@gmail.com \
    --cc=benoit.canet@gmail.com \
    --cc=benoit.canet@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).