* [Qemu-devel] [PATCH] thunk: improve readability of allocation loop
@ 2019-03-08 19:43 Aarushi Mehta
2019-03-09 14:28 ` Stefan Hajnoczi
2019-03-09 14:52 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Aarushi Mehta @ 2019-03-08 19:43 UTC (permalink / raw)
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Julia Suvorova, Stefan Hajnoczi
Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
---
thunk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/thunk.c b/thunk.c
index 17f3d320bb..7f31cffe09 100644
--- a/thunk.c
+++ b/thunk.c
@@ -86,7 +86,7 @@ void thunk_register_struct(int id, const char *name, const argtype *types)
#endif
/* now we can alloc the data */
- for(i = 0;i < 2; i++) {
+ for (i = 0; i < ARRAY_SIZE(se->field_offsets); i++) {
offset = 0;
max_align = 1;
se->field_offsets[i] = g_new(int, nb_fields);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] thunk: improve readability of allocation loop
2019-03-08 19:43 [Qemu-devel] [PATCH] thunk: improve readability of allocation loop Aarushi Mehta
@ 2019-03-09 14:28 ` Stefan Hajnoczi
2019-03-09 14:52 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2019-03-09 14:28 UTC (permalink / raw)
To: Aarushi Mehta
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Julia Suvorova
On Fri, Mar 8, 2019 at 7:43 PM Aarushi Mehta <mehta.aaru20@gmail.com> wrote:
>
> Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
> ---
> thunk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] thunk: improve readability of allocation loop
2019-03-08 19:43 [Qemu-devel] [PATCH] thunk: improve readability of allocation loop Aarushi Mehta
2019-03-09 14:28 ` Stefan Hajnoczi
@ 2019-03-09 14:52 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2019-03-09 14:52 UTC (permalink / raw)
To: Aarushi Mehta, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi, Julia Suvorova
On 08/03/2019 20:43, Aarushi Mehta wrote:
> Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
> ---
> thunk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/thunk.c b/thunk.c
> index 17f3d320bb..7f31cffe09 100644
> --- a/thunk.c
> +++ b/thunk.c
> @@ -86,7 +86,7 @@ void thunk_register_struct(int id, const char *name, const argtype *types)
> #endif
> /* now we can alloc the data */
>
> - for(i = 0;i < 2; i++) {
> + for (i = 0; i < ARRAY_SIZE(se->field_offsets); i++) {
> offset = 0;
> max_align = 1;
> se->field_offsets[i] = g_new(int, nb_fields);
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-09 14:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-08 19:43 [Qemu-devel] [PATCH] thunk: improve readability of allocation loop Aarushi Mehta
2019-03-09 14:28 ` Stefan Hajnoczi
2019-03-09 14:52 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).