From: Stefan Hajnoczi <stefanha@gmail.com>
To: Albert Esteve <aesteve@redhat.com>
Cc: "Viresh Kumar" <viresh.kumar@linaro.org>,
"Hanna Czenczek" <hreitz@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Garhwal, Vikram" <vikram.garhwal@amd.com>
Subject: Re: [PATCH] vhost-user: Fix protocol feature bit conflict
Date: Tue, 17 Oct 2023 10:46:37 -0400 [thread overview]
Message-ID: <CAJSP0QUUv357qFUrDbDBz8iybKB78uWicoz9ruXW9JQDcQi3Vw@mail.gmail.com> (raw)
In-Reply-To: <CADSE00LuFD9TxdVTBrPYqS0G_r_9fdht=BJf_2rG=F4sR-1fYA@mail.gmail.com>
On Tue, 17 Oct 2023 at 10:38, Albert Esteve <aesteve@redhat.com> wrote:
> On Tue, Oct 17, 2023 at 12:57 PM Stefan Hajnoczi <stefanha@gmail.com> wrote:
>>
>> On Tue, 17 Oct 2023 at 04:26, Albert Esteve <aesteve@redhat.com> wrote:
Thanks for considering my feedback!
> There is not. In a first thought, I assumed that the backends will be in charge
> of cleaning their entries from the shared hash table when they are destroyed
> (prematurely or no). I will look into occurrences of vhost_dev getting destroyed
> that may need explicit handling of the leftover entries.
QEMU supports hot (un)plug of vhost-user devices. vhost-user backends
may also crash.
QEMU cannot rely solely on the backend to take any cleanup action
because a backend may be buggy or misbehave.
Stefan
next prev parent reply other threads:[~2023-10-17 14:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 8:32 [PATCH] vhost-user: Fix protocol feature bit conflict Hanna Czenczek
2023-10-16 8:45 ` Manos Pitsidianakis
2023-10-16 10:32 ` Viresh Kumar
2023-10-16 11:40 ` Alex Bennée
2023-10-17 5:36 ` Viresh Kumar
2023-10-17 7:51 ` Hanna Czenczek
2023-10-17 7:53 ` Viresh Kumar
2023-10-17 8:14 ` Hanna Czenczek
2023-10-17 8:16 ` Viresh Kumar
2023-10-17 8:25 ` Albert Esteve
2023-10-17 10:56 ` Stefan Hajnoczi
2023-10-17 14:38 ` Albert Esteve
2023-10-17 14:46 ` Stefan Hajnoczi [this message]
2023-10-16 12:01 ` Manos Pitsidianakis
2023-10-16 10:40 ` Hanna Czenczek
2023-10-16 10:13 ` Stefano Garzarella
2023-10-16 14:03 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QUUv357qFUrDbDBz8iybKB78uWicoz9ruXW9JQDcQi3Vw@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=aesteve@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=hreitz@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vikram.garhwal@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).