From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38958)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1S6GlU-0003z4-C4
	for qemu-devel@nongnu.org; Sat, 10 Mar 2012 02:30:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1S6GlP-0003xV-Ks
	for qemu-devel@nongnu.org; Sat, 10 Mar 2012 02:30:55 -0500
Received: from mail-lpp01m010-f45.google.com ([209.85.215.45]:39641)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1S6GlP-0003wD-7v
	for qemu-devel@nongnu.org; Sat, 10 Mar 2012 02:30:51 -0500
Received: by lahe6 with SMTP id e6so2555231lah.4
	for <qemu-devel@nongnu.org>; Fri, 09 Mar 2012 23:30:49 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4F5A3B06.4000302@redhat.com>
References: <CAJSP0QUvcm_L4kf+6tDupQbEjAtLnOyEcTxddFqWVr4OY_k+NQ@mail.gmail.com>
	<20120309141653.GH4883@orkuz.home> <4F5A1DBB.3030606@laine.org>
	<CAJSP0QVaxmzxtF3Pko1JA2ty_W2_y92EX0FDFExJw422GuuZDw@mail.gmail.com>
	<4F5A3B06.4000302@redhat.com>
Date: Sat, 10 Mar 2012 07:30:48 +0000
Message-ID: <CAJSP0QUfv+Vy=10Nau33v6JzysAzdXKJ8JGdba_BhUWt=hGb+Q@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: libvir-list@redhat.com, Khoa Huynh <khoa@us.ibm.com>, George Wilson <gcwilson@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Laine Stump <laine@laine.org>

On Fri, Mar 9, 2012 at 5:16 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 09/03/2012 17:07, Stefan Hajnoczi ha scritto:
>>> > So am I correct that this extra permission is only needed for a singl=
e
>>> > RHEL6 release? If qemu won't be doing fstafs on an ongoing basis, it
>>> > doesn't seem like a good idea to permanently open up the permissions
>>> > allowed by virt_use_nfs
>> Paolo, your discard improvements in QEMU add FALLOC_FL_PUNCH_HOLE
>> support. =A0XFS supports this fallocate() flag in current kernels,
>> thereby making the XFS-specific support obsolete.
>>
>> I'm wondering whether it's worth expanding the SELinux policy if we
>> will have no fstatfs(2) callers in QEMU. =A0Are you planning to drop the
>> XFS code?
>
> Chris Wedgwood said that on XFS you want to do discard even if the file
> is preallocated, while this is not true on other filesystems. =A0So I
> guess the detection code should stay.

Okay.  I'll file a BZ as danpb suggests.

Stefan