From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55992)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZK5YL-0003Ef-B1
	for qemu-devel@nongnu.org; Tue, 28 Jul 2015 10:08:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZK5YH-0005Ic-Sv
	for qemu-devel@nongnu.org; Tue, 28 Jul 2015 10:08:21 -0400
Received: from mail-ob0-x236.google.com ([2607:f8b0:4003:c01::236]:33606)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZK5YH-0005IY-Nv
	for qemu-devel@nongnu.org; Tue, 28 Jul 2015 10:08:17 -0400
Received: by obdeg2 with SMTP id eg2so84982722obd.0
	for <qemu-devel@nongnu.org>; Tue, 28 Jul 2015 07:08:17 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1438085576-12072-1-git-send-email-stefanha@redhat.com>
References: <1438085576-12072-1-git-send-email-stefanha@redhat.com>
Date: Tue, 28 Jul 2015 15:08:17 +0100
Message-ID: <CAJSP0QUmgHD4edUMTgz-OO1+hYRbbS7E8UBM3QrcY0Knd4G0og@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v2 0/2] AioContext: fix deadlock after
 aio_context_acquire() race
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

On Tue, Jul 28, 2015 at 1:12 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> v2:
>  * Free BHs after thread_pool_free(), which calls qemu_bh_delete() [Cornelia]
>  * Remove assert for leaked BHs since we don't know how many existing cases
>    there are yet and QEMU 2.4-rc3 is a poor time to risk assertion failures

The v2 isn't necessary if we apply Paolo's "[PATCH for-2.4] block:
delete bottom halves before the AioContext is freed" on top of my v1.
Paolo has audited all BHs so the risk of hitting assertion failures is
very low.

Stefan