From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60281)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1StcRH-0008IL-7O
	for qemu-devel@nongnu.org; Tue, 24 Jul 2012 06:34:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1StcRA-0004xC-M3
	for qemu-devel@nongnu.org; Tue, 24 Jul 2012 06:34:03 -0400
Received: from mail-bk0-f45.google.com ([209.85.214.45]:62619)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1StcRA-0004wy-Cq
	for qemu-devel@nongnu.org; Tue, 24 Jul 2012 06:33:56 -0400
Received: by bkcji1 with SMTP id ji1so5207553bkc.4
	for <qemu-devel@nongnu.org>; Tue, 24 Jul 2012 03:33:55 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <500DBAD6.5050802@redhat.com>
References: <1342785709-3152-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1342785709-3152-9-git-send-email-stefanha@linux.vnet.ibm.com>
	<500DBAD6.5050802@redhat.com>
Date: Tue, 24 Jul 2012 11:33:55 +0100
Message-ID: <CAJSP0QUo4f7s_OfnZhme_ws92WQ2z4OFPvBDXMT9rXz2xESPPQ@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH 08/16] net: Remove VLANState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Zhi Yong Wu <wuzhy@cn.ibm.com>, qemu-devel@nongnu.org

On Mon, Jul 23, 2012 at 9:57 PM, Laszlo Ersek <lersek@redhat.com> wrote:
> On 07/20/12 14:01, Stefan Hajnoczi wrote:
>> @@ -970,7 +895,7 @@ void qmp_set_link(const char *name, bool up, Error **errp)
>>  done:
>>
>>      if (!vc) {
>> -        error_set(errp, QERR_DEVICE_NOT_FOUND, name);
>> +        qerror_report(QERR_DEVICE_NOT_FOUND, name);
>>          return;
>>      }
>
> Why? The only caller (at this point) seems to be hmp_set_link(), and it
> handles the error (with monitor_printf()).

Looks like a rebase/merge issue.  Thanks for pointing it out.

Stefan