From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bovFq-0005Fy-Sq for qemu-devel@nongnu.org; Tue, 27 Sep 2016 12:29:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bovFo-0004DW-Ma for qemu-devel@nongnu.org; Tue, 27 Sep 2016 12:29:13 -0400 MIME-Version: 1.0 In-Reply-To: <059434c4-67c0-9d8f-8089-e58d7fe952fc@redhat.com> References: <1474985217-21690-1-git-send-email-stefanha@redhat.com> <1474985217-21690-2-git-send-email-stefanha@redhat.com> <059434c4-67c0-9d8f-8089-e58d7fe952fc@redhat.com> From: Stefan Hajnoczi Date: Tue, 27 Sep 2016 17:29:11 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 1/3] coroutine: add qemu_coroutine_entered() function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Stefan Hajnoczi , qemu-devel , Kevin Wolf , Fam Zheng , qemu block , Roman Pen On Tue, Sep 27, 2016 at 5:20 PM, Paolo Bonzini wrote: > > > On 27/09/2016 16:06, Stefan Hajnoczi wrote: >> See the doc comments for a description of this new coroutine API. >> >> Signed-off-by: Stefan Hajnoczi >> --- >> include/qemu/coroutine.h | 13 +++++++++++++ >> util/qemu-coroutine.c | 5 +++++ >> 2 files changed, 18 insertions(+) >> >> diff --git a/include/qemu/coroutine.h b/include/qemu/coroutine.h >> index 29a2078..e6a60d5 100644 >> --- a/include/qemu/coroutine.h >> +++ b/include/qemu/coroutine.h >> @@ -92,6 +92,19 @@ Coroutine *coroutine_fn qemu_coroutine_self(void); >> */ >> bool qemu_in_coroutine(void); >> >> +/** >> + * Return true if the coroutine is currently entered >> + * >> + * A coroutine is "entered" if it has not yielded from the current >> + * qemu_coroutine_enter() call used to run it. This does not mean that the >> + * coroutine is currently executing code since it may have transferred control >> + * to another coroutine using qemu_coroutine_enter(). >> + * >> + * When several coroutines enter each other there may be no way to know which >> + * ones have already been entered. In such situations this function can be >> + * used to avoid recursively entering coroutines. >> + */ >> +bool qemu_coroutine_entered(Coroutine *co); > > Perhaps qemu_coroutine_running is a better name? I find "running" confusing since the coroutine may not actually be currently executing (as mentioned in the doc comment). Stefan