From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A05DEC7EE23 for ; Fri, 26 May 2023 10:57:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2V7K-0004BJ-C2; Fri, 26 May 2023 06:56:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2V7I-0004B0-Ln for qemu-devel@nongnu.org; Fri, 26 May 2023 06:56:16 -0400 Received: from mail-yw1-x1133.google.com ([2607:f8b0:4864:20::1133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2V7H-0004cp-1S for qemu-devel@nongnu.org; Fri, 26 May 2023 06:56:16 -0400 Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-561afe72a73so10799057b3.0 for ; Fri, 26 May 2023 03:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685098574; x=1687690574; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wBwoHGOTPdRBF9QuH3BagRUHLkxHjBwFzHq/xd5Hu0Q=; b=VfwdHfhx2223SoXj1S47Z9qxi0TQw45shm3wAVoJtZucHU/sOTZOz3hXV27vvDpNZ8 yO02KvPoJT7X7NzowWOvAVxr0rYxG3APhCvHvQnfoC2Q9qZpbRv5GYYvOsfQ8LSFk2l/ Bn7VvS8pzugLk3Y+yNX+AfNaINXc4bZPUygX9Ibtb9Z22CCqvsHp8YWuhLcc0tVWzydI jnib/t6Rr0c2AP/XKBh+9OJCLtPWH2UwoYyDE//MlSkTRbsMqkZpTw+DhUoTSQP/fTuX TjVkbnUbnz5zIP8M0URfOdl6ipWbI0clkrCIvvaJ0ddcG5qH27KVtgHpPqiLP1dE4A2z 80PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685098574; x=1687690574; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wBwoHGOTPdRBF9QuH3BagRUHLkxHjBwFzHq/xd5Hu0Q=; b=PLigdH+Q8VhMT9oAOHSoBktwmh+YJ1apxPhvn+3Fp79Hf8zrnb4lQwEEb/p2dHPL6R WwaZCr429jQUwD6zToeAtZ8l2yQZhCUJ3em2WPA/N5wttbyNn/EMHhgyFMGpyW6IDMaU iFOKiFfPsBIbnyw05SYCt0aHs8brvrDENZvS+n7IoGctvq0M4s8APWgZS4MZ4vSqRcOg +aDpOHQ/CPBzTE7UhPzPoJkZGMiUsqOP3Ulk5tsDQQtzCMbNMfDxHEh5YckuBfthenbG Sc0Bu6PR5CLYyffTLuHerhn77BxPaNE5Idj2//AGRAykI4lPYCDEQcYydJtFSGX4H++A oIlw== X-Gm-Message-State: AC+VfDyqWqoBjIldvDAWb1o0+aewhdxyFqpcYHfEF4jHLwzOewIC4vHQ Y694z/ztQZ4wOfgN1NI34QpgYFuB3JUJzLnJn2w= X-Google-Smtp-Source: ACHHUZ5qQI5ti8W6erf42uGk0nL/Cp03oOIN+tZCYoPGTBTNMlKLK1tDf0G3y8l5+y+dLmyIHu1MlAsAGHNVq+2NzpQ= X-Received: by 2002:a81:5209:0:b0:561:e540:b1b3 with SMTP id g9-20020a815209000000b00561e540b1b3mr1534380ywb.38.1685098573724; Fri, 26 May 2023 03:56:13 -0700 (PDT) MIME-Version: 1.0 References: <34c16474-2022-455a-a506-58a8d2b6c3a6@redhat.com> In-Reply-To: <34c16474-2022-455a-a506-58a8d2b6c3a6@redhat.com> From: Stefan Hajnoczi Date: Fri, 26 May 2023 06:56:01 -0400 Message-ID: Subject: Re: Performance improvement with 6d740fb01b9f0f5ea7a82f4d5e458d91940a19ee To: =?UTF-8?B?THVrw6HFoSBEb2t0b3I=?= Cc: Stefan Hajnoczi , qemu-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::1133; envelope-from=stefanha@gmail.com; helo=mail-yw1-x1133.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, 26 May 2023 at 04:07, Luk=C3=A1=C5=A1 Doktor w= rote: > > Dne 25. 05. 23 v 17:21 Stefan Hajnoczi napsal(a): > > On Thu, 25 May 2023 at 06:18, Luk=C3=A1=C5=A1 Doktor wrote: > >> the perf-ci detected and bisected the 6d740fb - aio-posix: do not nest= poll handlers - as a performance improvement when using multiple concurren= t jobs and 4k (22%) as well as 1024k (63%) blocks on aarch64 (on a slow rot= ational disk). > >> > >> https://ldoktor.github.io/tmp/RedHat-virtlab-arm09/v8.0.0/150-impr= ovement.html > >> > >> Based on the commit message I guess it's expected so take this just as= a record of an improvement. > > > > The commit was not intended to change performance and I'm not sure why > > it happens! > > > > It had and today the x86_64 pipeline finished which shows similar improve= ment just not in read but rather in write instead and only for 4k blocks (~= 40%). For 1024k blocks I can see it scoring a bit better (~1.5%). Reads are= too jittery to really tell anything on that machine. Anyway I have not don= e any thorough testing, just a bisection with the most significant setting. > > From around the same time I can see a NVMe regression in 4k writes, but f= irst bisection job showed nothing. I'll increase the range and try again as= each job since that day shows similar drop. Thanks! Stefan