From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58106)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Vz286-00059o-A0
	for qemu-devel@nongnu.org; Fri, 03 Jan 2014 05:37:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Vz285-00037J-5r
	for qemu-devel@nongnu.org; Fri, 03 Jan 2014 05:37:26 -0500
Received: from mail-oa0-x231.google.com ([2607:f8b0:4003:c02::231]:64165)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Vz285-00037B-0S
	for qemu-devel@nongnu.org; Fri, 03 Jan 2014 05:37:25 -0500
Received: by mail-oa0-f49.google.com with SMTP id i4so15861063oah.36
	for <qemu-devel@nongnu.org>; Fri, 03 Jan 2014 02:37:24 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1388062130-21126-1-git-send-email-pl@kamp.de>
References: <1388062130-21126-1-git-send-email-pl@kamp.de>
Date: Fri, 3 Jan 2014 18:37:23 +0800
Message-ID: <CAJSP0QUyhMohV7n22jytTgxtO8hyLgGnRKoxyBrVjuYWaikffA@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCHv5] block: add native support for NFS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, ronnie sahlberg <ronniesahlberg@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, Orit Wasserman <owasserm@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

Looks good.  In order to merge this new block driver qemu-iotests
support for nfs is required.  That way the block driver can be exercised
and checked for regressions (I guess you performed manual testing
during development).

Please see tests/qemu-iotests/common for examples of
NBD/SSH/Sheepdog/etc support.

The qemu-iotests test suite with raw, qcow2, and vmdk formats should
work on top of NFS.  Assuming you have an NFS server already running
on localhost, something like the following should succeed:

  cd tests/qemu-iotests
  ln -s ../../x86_64-softmmu/qemu-system-x86_64 qemu
  ln -s ../../qemu-img .
  ln -s ../../qemu-io .
  ./check -nfs # raw format by default
  ./check -nfs -qcow2
  ./check -nfs -vmdk

Maybe -nfs should take the base NFS URI as an argument to allow more
flexible test configurations.  It's up to you.

More info on qemu-iotests: http://qemu-project.org/Documentation/QemuIoTests