From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38890)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TgzC3-0007hV-Q7
	for qemu-devel@nongnu.org; Fri, 07 Dec 2012 09:46:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TgzBx-0001MW-VR
	for qemu-devel@nongnu.org; Fri, 07 Dec 2012 09:46:23 -0500
Received: from mail-lb0-f173.google.com ([209.85.217.173]:35916)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TgzBx-0001MS-OX
	for qemu-devel@nongnu.org; Fri, 07 Dec 2012 09:46:17 -0500
Received: by mail-lb0-f173.google.com with SMTP id c1so444757lbg.4
	for <qemu-devel@nongnu.org>; Fri, 07 Dec 2012 06:46:15 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <50C1F80A.2090807@redhat.com>
References: <1354740430-22452-1-git-send-email-stefanha@redhat.com>
	<1354740430-22452-5-git-send-email-stefanha@redhat.com>
	<50C1F80A.2090807@redhat.com>
Date: Fri, 7 Dec 2012 15:46:15 +0100
Message-ID: <CAJSP0QV2ZPTxrvqE5u9k6Cs4At79GiiZZB=sF8-RvVWvG_FrhA@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH v5 04/11] dataplane: add virtqueue vring
	code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Khoa Huynh <khoa@us.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Asias He <asias@redhat.com>

On Fri, Dec 7, 2012 at 3:07 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 05.12.2012 21:47, schrieb Stefan Hajnoczi:
>> The virtio-blk-data-plane cannot access memory using the usual QEMU
>> functions since it executes outside the global mutex and the memory APIs
>> are this time are not thread-safe.
>>
>> This patch introduces a virtqueue module based on the kernel's vhost
>> vring code.  The trick is that we map guest memory ahead of time and
>> access it cheaply outside the global mutex.
>>
>> Once the hardware emulation code can execute outside the global mutex it
>> will be possible to drop this code.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>>  hw/Makefile.objs           |   2 +-
>>  hw/dataplane/Makefile.objs |   2 +-
>>  hw/dataplane/vring.c       | 361 +++++++++++++++++++++++++++++++++++++++++++++
>>  hw/dataplane/vring.h       |  63 ++++++++
>>  trace-events               |   3 +
>>  5 files changed, 429 insertions(+), 2 deletions(-)
>>  create mode 100644 hw/dataplane/vring.c
>>  create mode 100644 hw/dataplane/vring.h
>>
>> diff --git a/hw/Makefile.objs b/hw/Makefile.objs
>> index d581d8d..cec84bc 100644
>> --- a/hw/Makefile.objs
>> +++ b/hw/Makefile.objs
>> @@ -1,4 +1,4 @@
>> -common-obj-y = usb/ ide/
>> +common-obj-y = usb/ ide/ dataplane/
>>  common-obj-y += loader.o
>>  common-obj-$(CONFIG_VIRTIO) += virtio-console.o
>>  common-obj-$(CONFIG_VIRTIO) += virtio-rng.o
>
> Shouldn't this hunk be in patch 3?

Yes, I'll move it.

Stefan