From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60303)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RlKHp-0002ct-WC
	for qemu-devel@nongnu.org; Thu, 12 Jan 2012 08:01:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RlKHh-0004Cq-7P
	for qemu-devel@nongnu.org; Thu, 12 Jan 2012 08:01:45 -0500
Received: from mail-wi0-f173.google.com ([209.85.212.173]:62434)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RlKHg-0004CJ-Q0
	for qemu-devel@nongnu.org; Thu, 12 Jan 2012 08:01:37 -0500
Received: by wibhm11 with SMTP id hm11so1418665wib.4
	for <qemu-devel@nongnu.org>; Thu, 12 Jan 2012 05:01:35 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4F0ECF5E.1040309@redhat.com>
References: <1325858501-25741-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1325858501-25741-12-git-send-email-stefanha@linux.vnet.ibm.com>
	<4F0ECF5E.1040309@redhat.com>
Date: Thu, 12 Jan 2012 13:01:35 +0000
Message-ID: <CAJSP0QV44pYXeFPHUEKRnrcvFDCWER4y5NieQN2Cy0MW6UikeQ@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 11/15] block: add bdrv_find_backing_image
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On Thu, Jan 12, 2012 at 12:17 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 06.01.2012 15:01, schrieb Stefan Hajnoczi:
>> +BlockDriverState *bdrv_find_backing_image(BlockDriverState *bs, const c=
har *id)
>> +{
>> + =A0 =A0if (!bs->drv) {
>> + =A0 =A0 =A0 =A0return NULL;
>> + =A0 =A0}
>> +
>> + =A0 =A0if (bs->backing_hd) {
>> + =A0 =A0 =A0 =A0if (strcmp(bs->backing_file, id) =3D=3D 0) {
>> + =A0 =A0 =A0 =A0 =A0 =A0return bs->backing_hd;
>
> So it's not really just some id, but the backing file name? I would find
> it clearer to reflect that in the parameter name and the QMP error in
> the next patch.

Okay, thanks.