[Qemu-devel] [PATCH 0/2] virtio-mmio: fix 2 bugs

[Qemu-devel] [PATCH 0/2] virtio-mmio: fix 2 bugs

[Ying-Shiuan Pan]

Hi, all

I'm not sure if it is appropriate to put patches here because
virtio-mmio is actually not in official repository yet.
In case that someone else wants to test virtio-mmio as I did, I decide
to send them out.

Currently, I've successfully tested virtio-blk, virtio-net, and virtio-balloon.

Ying-Shiuan Pan (2)
 virtio: fix switch-case in virtio_mmio_write()
 virtio: fix features negotiation

 hw/virtio-mmio.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)


----
Best Regards,
潘穎軒Ying-Shiuan Pan

Re: [Qemu-devel] [PATCH 0/2] virtio-mmio: fix 2 bugs

[Stefan Hajnoczi]

On Tue, Jan 3, 2012 at 7:05 AM, Ying-Shiuan Pan
<yingshiuan.pan@gmail.com> wrote:
> I'm not sure if it is appropriate to put patches here because
> virtio-mmio is actually not in official repository yet.

It's worth CCing Peter Maydell and Pawel on this because they are
working on virtio-mmio.

Stefan

Re: [Qemu-devel] [PATCH 0/2] virtio-mmio: fix 2 bugs

[Peter Maydell]

On 3 January 2012 07:05, Ying-Shiuan Pan <yingshiuan.pan@gmail.com> wrote:
> I'm not sure if it is appropriate to put patches here because
> virtio-mmio is actually not in official repository yet.
> In case that someone else wants to test virtio-mmio as I did, I decide
> to send them out.
>
> Currently, I've successfully tested virtio-blk, virtio-net, and virtio-balloon.

Thanks for tracking down these bugs and providing fixes. If it's OK with
you, I think I'll simply fold them in to my patches, since they haven't
been submitted upstream yet (the virtio subsystem needs splitting
out to have a cleaner backend/transport separation first).

-- PMM

Re: [Qemu-devel] [PATCH 0/2] virtio-mmio: fix 2 bugs

[Ying-Shiuan Pan]

2012/1/3 Peter Maydell <peter.maydell@linaro.org>:
> On 3 January 2012 07:05, Ying-Shiuan Pan <yingshiuan.pan@gmail.com> wrote:
>> I'm not sure if it is appropriate to put patches here because
>> virtio-mmio is actually not in official repository yet.
>> In case that someone else wants to test virtio-mmio as I did, I decide
>> to send them out.
>>
>> Currently, I've successfully tested virtio-blk, virtio-net, and virtio-balloon.
>
> Thanks for tracking down these bugs and providing fixes. If it's OK with
> you, I think I'll simply fold them in to my patches, since they haven't
> been submitted upstream yet (the virtio subsystem needs splitting
> out to have a cleaner backend/transport separation first).
>
> -- PMM

Yah~ it's ok, that's my pleasure!
Hope you can complete them soon~

----
Best Regards,
潘穎軒Ying-Shiuan Pan

Re: [Qemu-devel] [PATCH 0/2] virtio-mmio: fix 2 bugs

[Stefan Hajnoczi]

On Tue, Jan 3, 2012 at 10:30 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 3 January 2012 07:05, Ying-Shiuan Pan <yingshiuan.pan@gmail.com> wrote:
>> I'm not sure if it is appropriate to put patches here because
>> virtio-mmio is actually not in official repository yet.
>> In case that someone else wants to test virtio-mmio as I did, I decide
>> to send them out.
>>
>> Currently, I've successfully tested virtio-blk, virtio-net, and virtio-balloon.
>
> Thanks for tracking down these bugs and providing fixes. If it's OK with
> you, I think I'll simply fold them in to my patches, since they haven't
> been submitted upstream yet (the virtio subsystem needs splitting
> out to have a cleaner backend/transport separation first).

The virtio transport separation in QEMU is something I mean to look
into.  I've talked with Anthony in the past about the transport (e.g.
PCI) providing a virtio bus, which allows us to reuse qdev/QOM in a
more natural way.  Today the hw/virtio* code is glued together in an
ad-hoc way.  9pfs has started to factor out the virtio-9p-pci device.
It's time to put a good solution in place for all virtio devices.

Stefan