From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB269-0005SE-SP for qemu-devel@nongnu.org; Tue, 13 Jan 2015 09:05:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB265-0004J5-M7 for qemu-devel@nongnu.org; Tue, 13 Jan 2015 09:05:33 -0500 Received: from mail-ob0-x22e.google.com ([2607:f8b0:4003:c01::22e]:46452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB265-0004In-9c for qemu-devel@nongnu.org; Tue, 13 Jan 2015 09:05:29 -0500 Received: by mail-ob0-f174.google.com with SMTP id uz6so2589777obc.5 for ; Tue, 13 Jan 2015 06:05:28 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20150106140224.GK29775@stefanha-thinkpad.redhat.com> Date: Tue, 13 Jan 2015 14:05:28 +0000 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v4] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid Cc: Peter Maydell , qemu-devel qemu-devel On Tue, Jan 6, 2015 at 3:04 PM, Programmingkid wrote: > > On Jan 6, 2015, at 9:02 AM, Stefan Hajnoczi wrote: > >> On Fri, Jan 02, 2015 at 04:44:38PM -0500, Programmingkid wrote: >>> Removes redundant ret variable and renames sectorSize variable to meet QEMU coding standards. >> >> This is a changelog item for v4 of this patch. Changelogs should go >> below the '---' line so they are not merged into git history. >> >> The rationale is that when a patch is merged into git, the changelog >> describing patch revisions that were posted on the mailing list is not >> relevant (we only see the final patch in git, not the revisions from the >> mailing list). >> >> Patches usually look like this: >> >> Subject: block/raw-posix: brief summary >> >> A longer description of the problem, maybe a command-line to reproduce a >> bug, and some rationale for this code change. >> >> Signed-off-by: Me >> --- >> v2: >> * Fix int -> size_t for memory lengths [Requested by Bob] >> >> The changelog at the bottom is useful to code reviewers but won't get >> merged in the git history. >> >> Anyway, thanks for this patch. I have dropped this changelog line and >> merged it! >> >>> >>> Signed-off-by: John Arbuckle >>> >>> --- >>> block/raw-posix.c | 18 +++++++++++++++++- >>> configure | 2 +- >>> 2 files changed, 18 insertions(+), 2 deletions(-) >> >> Thanks, applied to my block tree: >> https://github.com/stefanha/qemu/commits/block >> >> Stefan > > Thank you very much for accepting my patch. Hi, Unfortunately I had to drop this patch because it breaks -drive file=/dev/null,... /dev/null is a character device and we should not return -ENOTSUP when the CD-ROM ioctls fail. Please let it fail gracefully when the device is not a CD-ROM. Stefan