From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55576)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QowOu-0003WB-2v
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 07:47:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QowOs-0008GI-TH
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 07:47:44 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:55056)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QowOs-0008G5-Qp
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 07:47:42 -0400
Received: by gxk26 with SMTP id 26so1164158gxk.4
	for <qemu-devel@nongnu.org>; Thu, 04 Aug 2011 04:47:42 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <87hb5x1kyw.fsf@skywalker.in.ibm.com>
References: <1312452371-10375-1-git-send-email-harsh@linux.vnet.ibm.com>
	<1312452371-10375-3-git-send-email-harsh@linux.vnet.ibm.com>
	<CAJSP0QXviHC8YrweEPTa9MnT2e0mg6cpiLWBA3mwTnB6qCHdRA@mail.gmail.com>
	<87hb5x1kyw.fsf@skywalker.in.ibm.com>
Date: Thu, 4 Aug 2011 12:47:42 +0100
Message-ID: <CAJSP0QVCD4ZNzA0pwpqTNu-gtSCCQtTVUCRSvwix2CaVpMf3eA@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for
 handle based fs driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On Thu, Aug 4, 2011 at 12:20 PM, Aneesh Kumar K.V
<aneesh.kumar@linux.vnet.ibm.com> wrote:
> On Thu, 4 Aug 2011 11:21:05 +0100, Stefan Hajnoczi <stefanha@gmail.com> w=
rote:
>> On Thu, Aug 4, 2011 at 11:06 AM, Harsh Prateek Bora
>> <harsh@linux.vnet.ibm.com> wrote:
>> > This patch provides support for st_gen for handle based fs type server=
.
>> > Currently the support is provided for ext4, btrfs, reiserfs and xfs.
>> >
>> > Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
>> > ---
>> > =A0hw/9pfs/virtio-9p-handle.c | =A0 30 ++++++++++++++++++++++++++++++
>> > =A01 files changed, 30 insertions(+), 0 deletions(-)
>>
>> Does handle-based file I/O really need to duplicate all this code? =A0Is
>> it possible to use either regular open or handle-based open from a
>> single local fs codebase?
>
> The only details common between handle based and local based getversion
> callback is the ioctl. Moving that into a helper may not really help in
> this case ?.

Aneesh, do you have a public virtfs tree that I can look at?  In
qemu.git we don't have virtio-9p-handle.c yet, so I can't give any
specific feedback.

Stefan