From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCqBV-00047Y-Ot for qemu-devel@nongnu.org; Wed, 28 Mar 2012 06:33:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCqBO-0006C0-Tc for qemu-devel@nongnu.org; Wed, 28 Mar 2012 06:32:57 -0400 Received: from mail-lpp01m010-f45.google.com ([209.85.215.45]:51362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCqBO-00066c-IA for qemu-devel@nongnu.org; Wed, 28 Mar 2012 06:32:50 -0400 Received: by lahe6 with SMTP id e6so1103065lah.4 for ; Wed, 28 Mar 2012 03:32:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4F722982.5020303@weilnetz.de> References: <1331751444-30905-1-git-send-email-sw@weilnetz.de> <4F60ECB4.6050006@redhat.com> <4F610431.7090005@weilnetz.de> <4F722982.5020303@weilnetz.de> Date: Wed, 28 Mar 2012 11:32:47 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Fix call syntax for qemu-img List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Kevin Wolf , Eric Blake , qemu-devel@nongnu.org On Tue, Mar 27, 2012 at 9:56 PM, Stefan Weil wrote: > Am 14.03.2012 21:48, schrieb Stefan Weil: > >> Am 14.03.2012 20:08, schrieb Eric Blake: >>> >>> On 03/14/2012 12:57 PM, Stefan Weil wrote: >>>> >>>> qemu-img requires first options, then file name, then size. >>>> >>>> GNU getopt also allows options at the end, but POSIX getopt >>>> doesn't. Try "export POSIXLY_CORRECT=y" to get the POSIX >>>> behaviour with GNU getopt, too. >>> >>> >>> That's a heavy sledgehammer, that has the potential to affect a lot of >>> other programs called alongside qemu-img. Simpler would be to just pass >>> -- in the command line at the point where you want to force qemu to >>> treat all further arguments without getopt reordering them, as in: >> >> >> I did not want to suggest that POSIXLY_CORRECT should always >> be set. It's just a way how maintainers can test that there is >> a problem with the current code, and that this problem is >> fixed by my patch. >> >> Passing -- in the command line will not only stop argument >> reordering, it also stops argument parsing which is not >> what we need here. >> >> Regards, >> >> Stefan W. > > > Ping? These two patches for qemu-iotests are still missing > in QEMU git master. Are there any open questions, or can > they be committed? Should they go through qemu-trivial? Kevin on IRC yesterday: Last week was rather busy, and I'll be on vacation from tomorrow until Friday, so don't expect feedback from me before some time next week Stefan