From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54588)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Ri764-0001yS-12
	for qemu-devel@nongnu.org; Tue, 03 Jan 2012 11:20:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Ri763-0006VD-0z
	for qemu-devel@nongnu.org; Tue, 03 Jan 2012 11:20:19 -0500
Received: from mail-ww0-f53.google.com ([74.125.82.53]:39556)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Ri762-0006Up-SC
	for qemu-devel@nongnu.org; Tue, 03 Jan 2012 11:20:18 -0500
Received: by wgbds1 with SMTP id ds1so25502326wgb.10
	for <qemu-devel@nongnu.org>; Tue, 03 Jan 2012 08:20:18 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4F03254E.5020204@redhat.com>
References: <1325604879-15862-1-git-send-email-owasserm@redhat.com>
	<1325604879-15862-9-git-send-email-owasserm@redhat.com>
	<CAJSP0QUtOidhXSZvGB2noAqOqoRObgDU6U+brrrz5_-ncmWoxw@mail.gmail.com>
	<4F03254E.5020204@redhat.com>
Date: Tue, 3 Jan 2012 16:20:17 +0000
Message-ID: <CAJSP0QVEf01x5J8_rsACOR1CH4-zzu0GGfXNAmQt8vBrmdwgdg@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 8/9] QMP commands changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Orit Wasserman <owasserm@redhat.com>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, quintela@redhat.com

On Tue, Jan 3, 2012 at 3:57 PM, Orit Wasserman <owasserm@redhat.com> wrote:
> On 01/03/2012 05:47 PM, Stefan Hajnoczi wrote:
>> On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman <owasserm@redhat.com> wro=
te:
>>> + =A0 =A0 =A0 =A0.args_type =A0=3D "detach:-d,blk:-b,inc:-i,xbrle:-x,ur=
i:s",
>>> + =A0 =A0 =A0 =A0.params =A0 =A0 =3D "[-d] [-b] [-i] [-x] uri",
>>> + =A0 =A0 =A0 =A0.help =A0 =A0 =A0 =3D "migrate to URI"
>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"\n\t -d to not wait for c=
ompletion"
>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"\n\t -b for migration wit=
hout shared storage with"
>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0" full copy of disk"
>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"\n\t -i for migration wit=
hout"
>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0" shared storage with incr=
emental copy of disk"
>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0" (base image shared betwe=
en source and destination)"
>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"\n\t -x to use XBRLE page=
 delta compression",
>>
>> It's too bad that this algorithm is user-visible and needs to be
>> expicitly enabled/disabled. =A0I think it would be useful in a much
>> wider range of cases if the trade-offs were understood well enough so
>> that QEMU can include a threshold or heuristic which chooses the
>> migration algorithm behind the scenes.
>
> I agree that an automatic switching on/off XBRLE is very desirable.
> At the first phase we merge it as a user option, and the in the next phas=
e will be adding
> the part that switch it on/off.

Okay, if there's an intent to do that next phase then great.  I'll
take a look at this series and review it soon.

Stefan