From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] raw-posix: inline paio_ioctl into hdev_aio_ioctl
Date: Fri, 2 Nov 2012 20:40:36 +0100 [thread overview]
Message-ID: <CAJSP0QVMOxnUpXLscr-nPtkwdY6OR+naBc-AucC7gi1ch7ALdA@mail.gmail.com> (raw)
In-Reply-To: <1351869260-26083-1-git-send-email-pbonzini@redhat.com>
On Fri, Nov 2, 2012 at 4:14 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> clang now warns about an unused function:
> CC block/raw-posix.o
> block/raw-posix.c:707:26: warning: unused function paio_ioctl
> [-Wunused-function]
> static BlockDriverAIOCB *paio_ioctl(BlockDriverState *bs, int fd,
> ^
> 1 warning generated.
>
> because the only use of paio_ioctl() is inside a #if defined(__linux__)
> guard and it is static now.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/raw-posix.c | 27 ++++++++++-----------------
> 1 file modificato, 10 inserzioni(+), 17 rimozioni(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2012-11-02 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 15:14 [Qemu-devel] [PATCH] raw-posix: inline paio_ioctl into hdev_aio_ioctl Paolo Bonzini
2012-11-02 19:40 ` Stefan Hajnoczi [this message]
2012-11-19 11:53 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QVMOxnUpXLscr-nPtkwdY6OR+naBc-AucC7gi1ch7ALdA@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).