From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Laurent Vivier" <laurent@vivier.eu>
Cc: Helge Deller <deller@gmx.de>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>
Subject: Re: [PULL 00/12] linux-user patches
Date: Sat, 17 Sep 2022 16:11:39 -0400 [thread overview]
Message-ID: <CAJSP0QVNsqY7ovqJSXgHraX=z_WSTwUXhh520oki2soJ3pa=NA@mail.gmail.com> (raw)
In-Reply-To: <467e4795-31ea-54b7-1735-ef5c2857ca5f@amsat.org>
On Sat, 17 Sept 2022 at 15:31, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 17/9/22 16:26, Stefan Hajnoczi wrote:
> > The close_range(2) man page says:
> > close_range() first appeared in Linux 5.9. Library support was added
> > in glibc in version 2.34.
> >
> > The qemu-user GitLab CI jobs are failing. For example, see
> > https://gitlab.com/qemu-project/qemu/-/jobs/3043629417:
> >
> > ../linux-user/syscall.c:8734:26: error: implicit declaration of
> > function 'close_range' is invalid in C99
> > [-Werror,-Wimplicit-function-declaration]
> > return get_errno(close_range(arg1, arg2, arg3));
> > ^
> >
> > There is a second issue with this pull request:
> > ../linux-user/syscall.c:357:16: error: ‘pidfd_getfd’ defined but not
> > used [-Werror=unused-function]
> > 357 | _syscall3(int, pidfd_getfd, int, pidfd, int, targetfd, unsigned
> > int, flags);
> > | ^~~~~~~~~~~
> > ../linux-user/syscall.c:251:13: note: in definition of macro ‘_syscall3’
> >
> > See https://gitlab.com/qemu-project/qemu/-/jobs/3043629434.
>
> Hmm apparently this PR hasn't been reviewed (although the patches were
> on the list for 2 weeks).
>
> The 'check DCO' job - looking for S-o-b tags - is green:
> https://gitlab.com/qemu-project/qemu/-/jobs/3043629425.
> Should we complete it by a R-b/A-b check over the commit range?
In some areas there will be no R-b/A-b, so I don't think we can
require those checks.
Was this pull request supposed to go through Laurent instead of being
applied directly by me?
Stefan
next prev parent reply other threads:[~2022-09-17 20:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 19:13 [PULL 00/12] linux-user patches Helge Deller
2022-09-13 19:13 ` [PULL 01/12] linux-user: Add missing signals in strace output Helge Deller
2022-09-13 19:13 ` [PULL 02/12] linux-user: Add missing clock_gettime64() syscall strace Helge Deller
2022-09-13 19:13 ` [PULL 03/12] linux-user: Add pidfd_open(), pidfd_send_signal() and pidfd_getfd() syscalls Helge Deller
2022-09-13 19:13 ` [PULL 04/12] linux-user: Log failing executable in EXCP_DUMP() Helge Deller
2022-09-13 19:13 ` [PULL 05/12] linux-user/hppa: Use EXCP_DUMP() to show enhanced debug info Helge Deller
2022-09-13 19:13 ` [PULL 06/12] linux-user/hppa: Dump IIR on register dump Helge Deller
2022-09-13 19:13 ` [PULL 07/12] linux-user: Fix strace of chmod() if mode == 0 Helge Deller
2022-09-13 19:13 ` [PULL 08/12] linux-user/hppa: Set TASK_UNMAPPED_BASE to 0xfa000000 for hppa arch Helge Deller
2022-09-13 19:13 ` [PULL 09/12] linux-user: Add strace for clock_nanosleep() Helge Deller
2022-09-13 19:13 ` [PULL 10/12] linux-user: Show timespec on strace for futex() Helge Deller
2022-09-13 19:13 ` [PULL 11/12] linux-user: Add close_range() syscall Helge Deller
2022-09-13 19:13 ` [PULL 12/12] linux-user: Add parameters of getrandom() syscall for strace Helge Deller
2022-09-17 14:26 ` [PULL 00/12] linux-user patches Stefan Hajnoczi
2022-09-17 19:31 ` Philippe Mathieu-Daudé via
2022-09-17 20:11 ` Stefan Hajnoczi [this message]
2022-09-18 18:52 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJSP0QVNsqY7ovqJSXgHraX=z_WSTwUXhh520oki2soJ3pa=NA@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=deller@gmx.de \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).