From: Stefan Hajnoczi <stefanha@gmail.com>
To: Patrick Jackson <patricksjackson@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller.
Date: Mon, 22 Aug 2011 21:41:42 +0100 [thread overview]
Message-ID: <CAJSP0QVeeDC1DLhoaVQFLAqu7ef+ep9j+xquEi4f=wkjBKh4OA@mail.gmail.com> (raw)
In-Reply-To: <4E5264B5.4010002@redhat.com>
On Mon, Aug 22, 2011 at 3:16 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 08/22/2011 02:04 PM, Stefan Hajnoczi wrote:
>>
>> Please use the block layer instead of reinventing portable file I/O.
>>
>> Also, please check which of the utility functions already exist in
>> QEMU. If a utility function in this patch is needed it should be made
>> generic for all of QEMU, not just goldfish or nand.
>
> This was part of the plans, but there was no time for it.
Does that mean this series is Request For Comments and not something
you expect to be merged into qemu.git?
Stefan
next prev parent reply other threads:[~2011-08-22 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 9:39 [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller Patrick Jackson
2011-08-22 12:04 ` Stefan Hajnoczi
2011-08-22 14:16 ` Paolo Bonzini
2011-08-22 20:41 ` Stefan Hajnoczi [this message]
2011-08-23 7:17 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJSP0QVeeDC1DLhoaVQFLAqu7ef+ep9j+xquEi4f=wkjBKh4OA@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=patricksjackson@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).