From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59832)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YPuAq-00036Z-Vx
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 09:40:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YPuAX-0006s8-VS
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 09:39:52 -0500
Received: from mail-ob0-x22e.google.com ([2607:f8b0:4003:c01::22e]:61813)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YPuAX-0006rx-RG
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 09:39:33 -0500
Received: by mail-ob0-f174.google.com with SMTP id wo20so36257094obc.5
	for <qemu-devel@nongnu.org>; Mon, 23 Feb 2015 06:39:33 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20150223134501.GA2102@potion.brq.redhat.com>
References: <1424373859-2019-1-git-send-email-rkrcmar@redhat.com>
	<20150219203101.GA3974@potion.brq.redhat.com>
	<20150223104546.GE27533@stefanha-thinkpad.redhat.com>
	<20150223134501.GA2102@potion.brq.redhat.com>
Date: Mon, 23 Feb 2015 14:39:33 +0000
Message-ID: <CAJSP0QVi_9XAOKe_yF9HfY7TunAC19xWeyZF95H1eLagWdhoAw@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Wei Huang <wehuang@redhat.com>

On Mon, Feb 23, 2015 at 1:45 PM, Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redha=
t.com> wrote:
> 2015-02-23 10:45+0000, Stefan Hajnoczi:
>> On Thu, Feb 19, 2015 at 09:37:46PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 wr=
ote:
>> > 2015-02-19 20:24+0100, Radim Kr=C4=8Dm=C3=A1=C5=99:
>> > > diff --git a/hw/net/e1000.c b/hw/net/e1000.c
>> > > @@ -138,6 +138,10 @@ typedef struct E1000State_st {
>> > > +#define E1000_WIN8_WORKAROUND_ICR       E1000_ICR_RXT0
>> > > +#define E1000_WIN8_WORKAROUND_DELAY_US  10
>> > > +    bool win8_workaround_needed;
>> > > @@ -288,7 +292,7 @@ set_interrupt_cause(E1000State *s, int index, ui=
nt32_t val)
>> > > @@ -316,13 +320,17 @@ set_interrupt_cause(E1000State *s, int index, =
uint32_t val)
>> > > +        if (s->win8_workround_needed) {
>> >
>> > So I read the patch again and noticed a typo here, which reminds me th=
at
>> > QEMU does not compile on rawhide for several reasons ...
>> > I'll fix that to compensate.
>>
>> Just to clarify, you are NACKing this patch and will send a new series?
>
> I would only change this line in v2 so far, so I wait for more comments
> before respin.  It is possible that maintainers find fixing a typo
> easier than handling v2, but it most likely is a NACK.

Since the typo breaks compilation, it shows that the patch was not
tested.  That makes me nervous.

Please send v2 after testing the Windows 8 guest.

Stefan