From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjjUd-0002yZ-QC for qemu-devel@nongnu.org; Tue, 13 Sep 2016 04:55:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjjUZ-00053G-RL for qemu-devel@nongnu.org; Tue, 13 Sep 2016 04:55:03 -0400 Received: from mail-vk0-f68.google.com ([209.85.213.68]:34328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjjUZ-000539-Ky for qemu-devel@nongnu.org; Tue, 13 Sep 2016 04:54:59 -0400 Received: by mail-vk0-f68.google.com with SMTP id m62so7371325vkd.1 for ; Tue, 13 Sep 2016 01:54:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1473689334-29138-1-git-send-email-stefanha@redhat.com> From: Stefan Hajnoczi Date: Tue, 13 Sep 2016 09:53:58 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PULL 00/17] Block patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Stefan Hajnoczi , QEMU Developers On Mon, Sep 12, 2016 at 4:56 PM, Peter Maydell wrote: > On 12 September 2016 at 16:12, Peter Maydell wrote: >> On 12 September 2016 at 15:08, Stefan Hajnoczi wrote: >>> The following changes since commit c2a57aae9a1c3dd7de77daf5478df10379aeeebf: >>> >>> Merge remote-tracking branch 'remotes/famz/tags/docker-pull-request' into staging (2016-09-09 12:49:41 +0100) >>> >>> are available in the git repository at: >>> >>> git://github.com/stefanha/qemu.git tags/block-pull-request >>> >>> for you to fetch changes up to 8f1096787517c66b67cc29bab65edc0188a86326: >>> >>> tests: fix qvirtqueue_kick (2016-09-12 15:06:29 +0100) >> >> >> /replication/primary/get_error: OK >> /replication/secondary/get_error: OK >> >> Please can you rename these tests? They create false positives in >> scripts that look in the build logs for errors by grepping for >> "error:" or "warning:". > > Also, two new sanitizer errors: > > /home/petmay01/linaro/qemu-for-merges/block/qcow2.c:1807:41: runtime > error: null pointer passed as argument 2, which is declared to never > be null > /home/petmay01/linaro/qemu-for-merges/block/qcow2-cluster.c:86:26: > runtime error: null pointer passed as argument 2, which is declared to > never be null > > both attempts to memcpy() from a NULL source pointer while running > the tests/test-replication test. These sanitizer errors cannot be introduced by this pull request because no patches touched block/qcow2.c or block/qcow2-cluster.c. Strange. I will add a patch to fix them anyway. Stefan