From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36459)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1S7l1E-00045M-0q
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:01:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1S7l1C-0006o6-BD
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:01:19 -0400
Received: from mail-lpp01m010-f45.google.com ([209.85.215.45]:51929)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1S7l1C-0006nq-0v
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:01:18 -0400
Received: by lahe6 with SMTP id e6so1370242lah.4
	for <qemu-devel@nongnu.org>; Wed, 14 Mar 2012 03:01:15 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4F606A09.2080906@redhat.com>
References: <CAJSP0QVeBfWnw+qtw7CiU=A4LE+kNTOMb0B-EWR=aVvqJLRNTQ@mail.gmail.com>
	<00c1eea5-ccb2-4b54-89f8-bdbf00fdc8a4@zmail17.collab.prod.int.phx2.redhat.com>
	<CAJSP0QWpGoaNn_q41sUbsZn8h24hMUHFQV2V6PMr8x6isVso_w@mail.gmail.com>
	<4F5F48F9.7090501@redhat.com>
	<CAJSP0QUJf6tcB2FEBEJg3hLTORmNtc7+v36n6QmppDWRxO1TVQ@mail.gmail.com>
	<4F606A09.2080906@redhat.com>
Date: Wed, 14 Mar 2012 10:01:15 +0000
Message-ID: <CAJSP0QVq-kpjAWc-gS9e7J7T7agPyUAY1adv4AxzhL4=uc6mwg@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG
	format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: =?ISO-8859-1?Q?Marc=2DAndr=E9_Lureau?= <marcandre.lureau@redhat.com>, =?ISO-8859-1?Q?Marc=2DAndr=E9_Lureau?= <mlureau@redhat.com>, =?ISO-8859-1?Q?Marc=2DAndr=E9_Lureau?= <marcandre.lureau@gmail.com>, qemu-devel@nongnu.org

On Wed, Mar 14, 2012 at 9:51 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> =A0Hi,
>
>> The most practical first step would be simply sending the ppm over a
>> socket from ppm_save(). =A0The 'screendump' command today already blocks
>> so no new badness is being added. =A0There would be no threads or fancy
>> image encoding.
>
> Adding scaling / compression support will add more overhead though, so
> doing that without offloading screendump to a thread first is a bad idea
> I think. =A0Or at least have some numbers to see how bad it actually is.

I agree, that's why I suggest sending the ppm over a socket.  It
transports out the image data and QEMU itself doesn't do the
encoding/scaling.

Stefan