From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Steffen Görtz" <contrib@steffen-goertz.de>
Cc: qemu-devel <qemu-devel@nongnu.org>, Joel Stanley <joel@jms.id.au>,
Jim Mussared <jim@groklearning.com>,
Julia Suvorova <jusual@mail.ru>,
Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/7] tests: Add bbc:microbit / nRF51 test suite
Date: Wed, 8 Aug 2018 10:09:24 +0100 [thread overview]
Message-ID: <CAJSP0QVrWiKtuRW+-EjFSJxrvWLtXWxsDHuvAuEe6yXOLWb72A@mail.gmail.com> (raw)
In-Reply-To: <20180806100114.21410-4-contrib@steffen-goertz.de>
On Mon, Aug 6, 2018 at 11:01 AM, Steffen Görtz
<contrib@steffen-goertz.de> wrote:
> +#define PAGE_SIZE 1024
> +#define FLASH_SIZE (256 * PAGE_SIZE)
> +#define FLASH_BASE 0x00000000
> +#define UICR_BASE 0x10001000
> +#define UICR_SIZE 0x100
> +#define NVMC_BASE 0x4001E000UL
> +#define NVMC_READY 0x400
> +#define NVMC_CONFIG 0x504
> +#define NVMC_ERASEPAGE 0x508
> +#define NVMC_ERASEPCR1 0x508
> +#define NVMC_ERASEALL 0x50C
> +#define NVMC_ERASEPCR0 0x510
> +#define NVMC_ERASEUICR 0x514
All these constants could live in include/hw/arm/nrf51.h. That way
tests do not need to duplicate them. As more devices are implemented
we can expect this list to grow.
> +static void fill_and_erase(hwaddr base, hwaddr size, uint32_t address_reg)
Why hwaddr? writel() and friends use uint64_t.
next prev parent reply other threads:[~2018-08-08 9:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 10:01 [Qemu-devel] [PATCH 0/7] arm: nRF51 Devices and Microbit Support Steffen Görtz
2018-08-06 10:01 ` [Qemu-devel] [PATCH 1/7] hw/misc/nrf51_rng: Add NRF51 random number generator peripheral Steffen Görtz
2018-08-06 14:00 ` Stefan Hajnoczi
2018-08-16 15:45 ` Peter Maydell
2018-08-06 10:01 ` [Qemu-devel] [PATCH 2/7] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories Steffen Görtz
2018-08-06 16:09 ` Stefan Hajnoczi
2018-08-08 9:58 ` Steffen Görtz
2018-08-16 16:03 ` Peter Maydell
2018-08-21 8:31 ` Steffen Görtz
2018-08-06 10:01 ` [Qemu-devel] [PATCH 3/7] tests: Add bbc:microbit / nRF51 test suite Steffen Görtz
2018-08-08 9:09 ` Stefan Hajnoczi [this message]
2018-08-08 9:46 ` Julia Suvorova
2018-08-09 16:16 ` Stefan Hajnoczi
2018-08-06 10:01 ` [Qemu-devel] [PATCH 4/7] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral Steffen Görtz
2018-08-08 9:11 ` Stefan Hajnoczi
2018-08-16 16:08 ` Peter Maydell
2018-08-06 10:01 ` [Qemu-devel] [PATCH 5/7] tests/microbit-test: Add Tests for nRF51 GPIO Steffen Görtz
2018-08-09 16:14 ` Stefan Hajnoczi
2018-08-06 10:01 ` [Qemu-devel] [PATCH 6/7] hw/timer/nrf51_timer: Add nRF51 Timer peripheral Steffen Görtz
2018-08-09 16:45 ` Stefan Hajnoczi
2018-08-06 10:01 ` [Qemu-devel] [PATCH 7/7] hw/display/led_matrix: Add LED matrix display device Steffen Görtz
2018-08-09 17:08 ` Stefan Hajnoczi
2018-08-06 10:09 ` [Qemu-devel] [PATCH 0/7] arm: nRF51 Devices and Microbit Support Peter Maydell
2018-08-06 10:31 ` Steffen Görtz
2018-08-16 16:10 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QVrWiKtuRW+-EjFSJxrvWLtXWxsDHuvAuEe6yXOLWb72A@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=contrib@steffen-goertz.de \
--cc=jim@groklearning.com \
--cc=joel@jms.id.au \
--cc=jusual@mail.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).