From: Stefan Hajnoczi <stefanha@gmail.com>
To: Sage Weil <sage@newdream.net>
Cc: kwolf@redhat.com, ceph-devel@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] rbd: clean up, fix style
Date: Thu, 8 Sep 2011 10:48:50 +0100 [thread overview]
Message-ID: <CAJSP0QVyaZatW3kM10ZqWrTWPM_02vtmPxLJhtPySKkc1uMPwQ@mail.gmail.com> (raw)
In-Reply-To: <1315412886-21092-2-git-send-email-sage@newdream.net>
On Wed, Sep 7, 2011 at 5:28 PM, Sage Weil <sage@newdream.net> wrote:
> No assignment in condition. Remove duplicate ret > 0 check.
>
> Signed-off-by: Sage Weil <sage@newdream.net>
> ---
> block/rbd.c | 17 ++++++++---------
> 1 files changed, 8 insertions(+), 9 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
next prev parent reply other threads:[~2011-09-08 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 16:28 [Qemu-devel] [PATCH 1/3] rbd: allow client id to be specified in config string Sage Weil
2011-09-07 16:28 ` [Qemu-devel] [PATCH 2/3] rbd: clean up, fix style Sage Weil
2011-09-08 9:48 ` Stefan Hajnoczi [this message]
2011-09-07 16:28 ` [Qemu-devel] [PATCH 3/3] rbd: fix leak in qemu_rbd_open failure paths Sage Weil
2011-09-08 9:49 ` Stefan Hajnoczi
2011-09-08 9:48 ` [Qemu-devel] [PATCH 1/3] rbd: allow client id to be specified in config string Stefan Hajnoczi
2011-09-08 10:04 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QVyaZatW3kM10ZqWrTWPM_02vtmPxLJhtPySKkc1uMPwQ@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).