Re: [Qemu-devel] [PATCH v3] Support for UDP unicast network backend

[Stefan Hajnoczi <stefanha@gmail.com>]

On Tue, Jan 10, 2012 at 10:59 AM, Andreas Färber <andreas.faerber@web.de> wrote:
> Am 10.01.2012 17:21, schrieb Benjamin:
>> On 11/29/11 20:52, Stefan Hajnoczi wrote:
>>> On Tue, Nov 29, 2011 at 7:55 PM, Benjamin<mlspirat42@gmail.com>  wrote:
>>>>
>>>> Signed-off-by: Benjamin<mlspirat42@gmail.com>
>
> A minor nit: the SoB is a legal assertion that you not stole, etc. the
> code, and as such it should include first and last name.
>
>>>> ---
>>>>   net.c           |    6 ++++-
>>>>   net/socket.c    |   73
>>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>>>   qemu-options.hx |    2 +
>>>>   3 files changed, 78 insertions(+), 3 deletions(-)
>>>
>>> Reviewed-by: Stefan Hajnoczi<stefanha@linux.vnet.ibm.com>
>>>
>>>> +    s = net_socket_fd_init(vlan, model, name, fd, 0);
>>>> +    if (!s) {
>>>> +        return -1;
>>>> +    }
>>>
>>> I'll add a TODO to my list about net_socket_fd_init().  It does not
>>> consistently take ownership of fd.  It may return NULL without closing
>>> it, but then again it might close it on error in another code path :(.
>
> Hasn't this been taken care of in the meantime? Any changes needed for
> that, Stefan?

It's been taken care of, no changes are needed to this patch.

>> Me again, is it supposed to take that long before the patch is
>> accepted?
>
> Not supposed to, but sometimes it does...

This is ready to merge, we need a committer to take a look and apply it.

Stefan