From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43787)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RkZcK-0003LO-JR
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 06:11:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RkZcA-0003m4-Df
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 06:11:48 -0500
Received: from mail-we0-f173.google.com ([74.125.82.173]:43520)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RkZcA-0003lt-8M
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 06:11:38 -0500
Received: by werb10 with SMTP id b10so4135927wer.4
	for <qemu-devel@nongnu.org>; Tue, 10 Jan 2012 03:11:37 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4F0C19F4.9040701@web.de>
References: <1322596506-31056-1-git-send-email-mlspirat42@gmail.com>
	<CAJSP0QWbcwUFv-0yMx7hvJcsi+X3+VeLvpJA73OEK1taKXbtvw@mail.gmail.com>
	<4F0C6580.3000908@gmail.com> <4F0C19F4.9040701@web.de>
Date: Tue, 10 Jan 2012 11:11:37 +0000
Message-ID: <CAJSP0QVynTps25FuvKXr+OfJXNMj1JbjsSRPgJAwgYoTRUQuhA@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3] Support for UDP unicast network backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>, jan.kiszka@web.de, Benjamin <mlspirat42@gmail.com>, qemu-devel@nongnu.org

On Tue, Jan 10, 2012 at 10:59 AM, Andreas F=E4rber <andreas.faerber@web.de>=
 wrote:
> Am 10.01.2012 17:21, schrieb Benjamin:
>> On 11/29/11 20:52, Stefan Hajnoczi wrote:
>>> On Tue, Nov 29, 2011 at 7:55 PM, Benjamin<mlspirat42@gmail.com> =A0wrot=
e:
>>>>
>>>> Signed-off-by: Benjamin<mlspirat42@gmail.com>
>
> A minor nit: the SoB is a legal assertion that you not stole, etc. the
> code, and as such it should include first and last name.
>
>>>> ---
>>>> =A0 net.c =A0 =A0 =A0 =A0 =A0 | =A0 =A06 ++++-
>>>> =A0 net/socket.c =A0 =A0| =A0 73
>>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>>> =A0 qemu-options.hx | =A0 =A02 +
>>>> =A0 3 files changed, 78 insertions(+), 3 deletions(-)
>>>
>>> Reviewed-by: Stefan Hajnoczi<stefanha@linux.vnet.ibm.com>
>>>
>>>> + =A0 =A0s =3D net_socket_fd_init(vlan, model, name, fd, 0);
>>>> + =A0 =A0if (!s) {
>>>> + =A0 =A0 =A0 =A0return -1;
>>>> + =A0 =A0}
>>>
>>> I'll add a TODO to my list about net_socket_fd_init(). =A0It does not
>>> consistently take ownership of fd. =A0It may return NULL without closin=
g
>>> it, but then again it might close it on error in another code path :(.
>
> Hasn't this been taken care of in the meantime? Any changes needed for
> that, Stefan?

It's been taken care of, no changes are needed to this patch.

>> Me again, is it supposed to take that long before the patch is
>> accepted?
>
> Not supposed to, but sometimes it does...

This is ready to merge, we need a committer to take a look and apply it.

Stefan