From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famcool@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, hch@lst.de
Subject: Re: [Qemu-devel] [PATCH v8 09/12] VMDK: open/read/write for monolithicFlat image
Date: Fri, 8 Jul 2011 13:55:57 +0100 [thread overview]
Message-ID: <CAJSP0QWKcK5SdjBrQ18rzid2nAq_MLcK=3mbXJkcW22uNg5Pwg@mail.gmail.com> (raw)
In-Reply-To: <1309865478-32766-10-git-send-email-famcool@gmail.com>
On Tue, Jul 5, 2011 at 12:31 PM, Fam Zheng <famcool@gmail.com> wrote:
> + ret = sscanf(p, "%10s %lld %10s %512s",
[...]
> + ret = sscanf(p, "%10s %lld %10s %511s %lld",
%512s -> %511s
But instead of duplicating the format string and sscanf(3), I suggest
doing sscanf(p, "%10s %lld %10s %511s %lld", ...) once only.
After it returns you can check:
if (ret < 4) {
...fail...
} else if (!strcmp(access, "FLAT")) {
if (ret != 5 || flat_offset < 0) {
...fail...
}
} else {
if (ret != 4) {
...fail...
}
}
Stefan
next prev parent reply other threads:[~2011-07-08 12:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 11:31 [Qemu-devel] [PATCH v8 00/12] Adding VMDK monolithic flat support Fam Zheng
2011-07-05 11:31 ` [Qemu-devel] [PATCH v8 01/12] VMDK: introduce VmdkExtent Fam Zheng
2011-07-05 11:31 ` [Qemu-devel] [PATCH v8 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster Fam Zheng
2011-07-05 11:31 ` [Qemu-devel] [PATCH v8 03/12] VMDK: probe for monolithicFlat images Fam Zheng
2011-07-05 11:31 ` [Qemu-devel] [PATCH v8 04/12] VMDK: separate vmdk_open by format version Fam Zheng
2011-07-05 11:31 ` [Qemu-devel] [PATCH v8 05/12] VMDK: add field BDRVVmdkState.desc_offset Fam Zheng
2011-07-05 11:31 ` [Qemu-devel] [PATCH v8 06/12] VMDK: flush multiple extents Fam Zheng
2011-07-05 11:31 ` [Qemu-devel] [PATCH v8 07/12] VMDK: move 'static' cid_update flag to bs field Fam Zheng
2011-07-05 11:31 ` [Qemu-devel] [PATCH v8 08/12] VMDK: change get_cluster_offset return type Fam Zheng
2011-07-05 11:31 ` [Qemu-devel] [PATCH v8 09/12] VMDK: open/read/write for monolithicFlat image Fam Zheng
2011-07-08 12:55 ` Stefan Hajnoczi [this message]
2011-07-05 11:31 ` [Qemu-devel] [PATCH v8 10/12] VMDK: create different subformats Fam Zheng
2011-07-08 15:29 ` Stefan Hajnoczi
2011-07-09 12:09 ` Fam Zheng
2011-07-05 11:31 ` [Qemu-devel] [PATCH v8 11/12] VMDK: fix coding style Fam Zheng
2011-07-05 11:31 ` [Qemu-devel] [PATCH v8 12/12] block: add bdrv_get_allocated_file_size() operation Fam Zheng
2011-07-08 15:40 ` [Qemu-devel] [PATCH v8 00/12] Adding VMDK monolithic flat support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJSP0QWKcK5SdjBrQ18rzid2nAq_MLcK=3mbXJkcW22uNg5Pwg@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=famcool@gmail.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).