From: Stefan Hajnoczi <stefanha@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/2] block: set cache mode flags in a single place
Date: Thu, 4 Aug 2011 12:27:18 +0100 [thread overview]
Message-ID: <CAJSP0QWL5gsLVvyTEA27UtFqmW4HbVX3oCkmj4jsK96QcX1cng@mail.gmail.com> (raw)
In-Reply-To: <20110804111414.GA23952@lst.de>
On Thu, Aug 4, 2011 at 12:14 PM, Christoph Hellwig <hch@lst.de> wrote:
> On Thu, Aug 04, 2011 at 09:46:33AM +0100, Stefan Hajnoczi wrote:
>> +/**
>> + * Set open flags for a given cache mode
>> + *
>> + * Return 0 on success, -1 if the cache mode was invalid.
>> + */
>> +int bdrv_set_cache_flags(const char *mode, int *flags)
>
> I would call this bdrv_parse_cache_flags.
Fixed in v3.
Stefan
prev parent reply other threads:[~2011-08-04 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 8:46 [Qemu-devel] [PATCH v2 1/2] block: set cache mode flags in a single place Stefan Hajnoczi
2011-08-04 8:46 ` [Qemu-devel] [PATCH v2 2/2] block: add cache=directsync parameter to -drive Stefan Hajnoczi
2011-08-04 11:14 ` [Qemu-devel] [PATCH v2 1/2] block: set cache mode flags in a single place Christoph Hellwig
2011-08-04 11:27 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QWL5gsLVvyTEA27UtFqmW4HbVX3oCkmj4jsK96QcX1cng@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).