From: Stefan Hajnoczi <stefanha@gmail.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Alberto Garcia <berto@igalia.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v7 6/6] qemu-iotests: add 184 for throttle filter driver
Date: Fri, 25 Aug 2017 12:05:10 +0100 [thread overview]
Message-ID: <CAJSP0QWN3R=kd9299ziiHa3OEdPGGvM+1M6ZO1hkjKEgvnFmoA@mail.gmail.com> (raw)
In-Reply-To: <20170824211506.iygynkpevxemsyg2@postretch>
On Thu, Aug 24, 2017 at 10:15 PM, Manos Pitsidianakis
<el13635@mail.ntua.gr> wrote:
> On Thu, Aug 24, 2017 at 07:43:08PM +0100, Stefan Hajnoczi wrote:
>>
>> On Tue, Aug 22, 2017 at 01:15:35PM +0300, Manos Pitsidianakis wrote:
>>>
>>> +_supported_fmt qcow2
>>
>>
>> What makes this test qcow2-specific? With additional filtering for
>> IMGFMT it should be possible to run this on any image format.
>
>
> I think none of the available filters hide all of the image details in
> query-block and company. _filter_imgfmt hides the image extensions but not
> the image specific fields (eg virtual-size, actual-size and
> format-specific). Perhaps a new filter that hides everything but "format"
> and "filename" in the "image" subdict can be introduced later.
It's a little cumbersome to filter JSON in shell. The filters do not
use jq(1) at the moment.
Tests written in Python have an easier time of filtering certain
fields. I did that recently for QMP Event objects in 194.
Anyway, it's okay to keep this test qcow2-only for now.
Stefan
prev parent reply other threads:[~2017-08-25 11:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 10:15 [Qemu-devel] [PATCH v7 0/6] add throttle block driver filter Manos Pitsidianakis
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 1/6] block: move ThrottleGroup membership to ThrottleGroupMember Manos Pitsidianakis
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 2/6] block: add aio_context field in ThrottleGroupMember Manos Pitsidianakis
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 3/6] block: tidy ThrottleGroupMember initializations Manos Pitsidianakis
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 4/6] block: convert ThrottleGroup to object with QOM Manos Pitsidianakis
2017-08-22 13:25 ` Alberto Garcia
2017-08-22 13:31 ` Manos Pitsidianakis
2017-08-24 18:31 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 5/6] block: add throttle block filter driver Manos Pitsidianakis
2017-08-22 14:16 ` Alberto Garcia
2017-08-22 14:22 ` Manos Pitsidianakis
2017-08-24 18:39 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 6/6] qemu-iotests: add 184 for throttle " Manos Pitsidianakis
2017-08-23 8:57 ` Alberto Garcia
2017-08-24 18:43 ` Stefan Hajnoczi
2017-08-24 21:15 ` Manos Pitsidianakis
2017-08-25 11:05 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJSP0QWN3R=kd9299ziiHa3OEdPGGvM+1M6ZO1hkjKEgvnFmoA@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=berto@igalia.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).