From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Roman Pen <roman.penyaev@profitbricks.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] Revert "linux-aio: Cancel BH if not needed"
Date: Mon, 27 Jun 2016 16:09:48 +0100 [thread overview]
Message-ID: <CAJSP0QWUYYQNXQ32GOiWiUvUmGgfDvHpHhqndTnFtbHRTvGDfA@mail.gmail.com> (raw)
In-Reply-To: <20160624144605.GF5422@noname.redhat.com>
On Fri, Jun 24, 2016 at 3:46 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 24.06.2016 um 15:40 hat Roman Pen geschrieben:
>> This reverts commit ccb9dc10129954d0bcd7814298ed445e684d5a2a,
>> which causes MQ stuck while doing IO thru virtio_blk.
>
> It would be good to have a theory why this happens.
It's worth taking the batch notify BH out of the equation in
virtio_blk_data_plane_notify():
- set_bit(virtio_get_queue_index(vq), s->batch_notify_vqs);
- qemu_bh_schedule(s->bh);
+ if (virtio_should_notify(s->vdev, vq)) {
+ event_notifier_set(virtio_queue_get_guest_notifier(vq));
+ }
I wonder if that makes any difference?
I don't have a concrete theory why batch notify interferes with
Kevin's patch though.
Stefan
next prev parent reply other threads:[~2016-06-27 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 13:40 [Qemu-devel] [PATCH 1/1] Revert "linux-aio: Cancel BH if not needed" Roman Pen
2016-06-24 14:46 ` Kevin Wolf
2016-06-27 15:09 ` Stefan Hajnoczi [this message]
2016-06-28 8:41 ` Stefan Hajnoczi
2016-06-27 16:01 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QWUYYQNXQ32GOiWiUvUmGgfDvHpHhqndTnFtbHRTvGDfA@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=roman.penyaev@profitbricks.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).