From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45860)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1SxHrb-0002du-KN
	for qemu-devel@nongnu.org; Fri, 03 Aug 2012 09:24:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1SxHra-0000Wt-LP
	for qemu-devel@nongnu.org; Fri, 03 Aug 2012 09:24:23 -0400
Received: from mail-lb0-f173.google.com ([209.85.217.173]:41414)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1SxHra-0000Wi-DL
	for qemu-devel@nongnu.org; Fri, 03 Aug 2012 09:24:22 -0400
Received: by lbok6 with SMTP id k6so1517276lbo.4
	for <qemu-devel@nongnu.org>; Fri, 03 Aug 2012 06:24:20 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20120803100058.03948f71@doriath.home>
References: <1343991066-9814-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1343991066-9814-4-git-send-email-stefanha@linux.vnet.ibm.com>
	<20120803100058.03948f71@doriath.home>
Date: Fri, 3 Aug 2012 14:24:20 +0100
Message-ID: <CAJSP0QWVyJV5D0Ys5FSgDMD6+dio-csN_pSc1YzN_cmKnACgPQ@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH 3/7] remove unused include of error.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Amos Kong <akong@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On Fri, Aug 3, 2012 at 2:00 PM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> On Fri,  3 Aug 2012 11:51:02 +0100
> Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> wrote:
>
>> From: Amos Kong <akong@redhat.com>
>>
>> Signed-off-by: Amos Kong <akong@redhat.com>
>> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>> ---
>>  qemu_socket.h |    1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/qemu_socket.h b/qemu_socket.h
>> index 4689ff3..1a2f517 100644
>> --- a/qemu_socket.h
>> +++ b/qemu_socket.h
>> @@ -27,7 +27,6 @@ int inet_aton(const char *cp, struct in_addr *ia);
>>  #endif /* !_WIN32 */
>>
>>  #include "qemu-option.h"
>> -#include "error.h"
>>  #include "qerror.h"
>
> nack on this one, as it's dropping the wrong file.
>
> qemu_socket.h declares functions that take an Error argument, so it has
> to include error.h.
>
> However, qerror.h should be dropped and any build breakage should be
> fixed by including qerror.h in the .c files it's missing.

Okay, let's drop this patch.  I build tested it across all targets, so
at least it doesn't break anything.

Stefan