From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAhxG-0004Om-Uj for qemu-devel@nongnu.org; Thu, 22 Mar 2012 09:21:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAhxA-0007Wc-Fm for qemu-devel@nongnu.org; Thu, 22 Mar 2012 09:21:26 -0400 Received: from mail-lpp01m010-f45.google.com ([209.85.215.45]:40178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAhxA-0007W0-5x for qemu-devel@nongnu.org; Thu, 22 Mar 2012 09:21:20 -0400 Received: by lahe6 with SMTP id e6so1688233lah.4 for ; Thu, 22 Mar 2012 06:21:17 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1332345124-381-5-git-send-email-benoit.canet@gmail.com> References: <1332345124-381-1-git-send-email-benoit.canet@gmail.com> <1332345124-381-5-git-send-email-benoit.canet@gmail.com> Date: Thu, 22 Mar 2012 13:21:17 +0000 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2 4/7] qed: add bdrv_invalidate_cache to be called after incoming live migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Beno=EEt_Canet?= Cc: kwolf@redhat.com, pbonzini@redhat.com, Anthony Liguori , qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On Wed, Mar 21, 2012 at 3:52 PM, Beno=EEt Canet wr= ote: > The QED image is reopened to flush metadata and check consistency. > > Signed-off-by: Benoit Canet > --- > =A0block/qed.c | =A0 15 +++++++++++++++ > =A0block/qed.h | =A0 =A01 + > =A02 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/block/qed.c b/block/qed.c > index a041d31..c47272c 100644 > --- a/block/qed.c > +++ b/block/qed.c > @@ -375,6 +375,10 @@ static int bdrv_qed_open(BlockDriverState *bs, int f= lags) > =A0 =A0 int ret; > > =A0 =A0 s->bs =3D bs; > + > + =A0 =A0/* backup flags for bdrv_qed_invalidate_cache */ > + =A0 =A0s->flags =3D flags; It's not clear to me why we need to introduce this field to stash flags values. bs->open_flags already has this information. Originally this was introduced in 06d9260ffa9 ("qcow2: implement bdrv_invalidate_cache (v2)") for qcow2. I wonder if that field is necessary when we already have bs->open_flags. What I don't like about s->flags is that it duplicates state *and* it's done in each block driver that supports .bdrv_invalidate_cache(). So I wonder if we can drop it? Stefan