From: Stefan Hajnoczi <stefanha@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, kwolf@redhat.com
Subject: Re: [PATCH 2/4] coroutine: Move coroutine_fn to qemu/osdep.h, trim includes
Date: Thu, 8 Dec 2022 10:03:02 -0500 [thread overview]
Message-ID: <CAJSP0QWfZ11aoMEGH3NXa2bNi9K9xLxKPF_aJ0isSejiq2UAvg@mail.gmail.com> (raw)
In-Reply-To: <20221208142306.2642640-3-armbru@redhat.com>
On Thu, 8 Dec 2022 at 09:25, Markus Armbruster <armbru@redhat.com> wrote:
>
> block/block-hmp-cmds.h and qemu/co-shared-resource.h use coroutine_fn
> without including qemu/coroutine.h. They compile only if it's already
> included from elsewhere.
>
> I could fix that, but pulling in qemu/coroutine.h and everything it
> includes just for a macro that expands into nothing feels silly.
> Instead, move the macro to qemu/osdep.h.
>
> Inclusions of qemu/coroutine.h just for coroutine_fn become
> superfluous. Drop them.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/block/aio_task.h | 2 --
> include/block/block-common.h | 1 -
> include/monitor/hmp.h | 1 -
> include/qemu/coroutine.h | 18 +++++++-----------
> include/qemu/osdep.h | 16 ++++++++++++++++
> 5 files changed, 23 insertions(+), 15 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2022-12-08 15:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 14:23 [PATCH 0/4] coroutine: Clean up includes Markus Armbruster
2022-12-08 14:23 ` [PATCH 1/4] coroutine: Clean up superfluous inclusion of qemu/coroutine.h Markus Armbruster
2022-12-08 14:59 ` Stefan Hajnoczi
2022-12-08 17:56 ` Markus Armbruster
2022-12-08 14:23 ` [PATCH 2/4] coroutine: Move coroutine_fn to qemu/osdep.h, trim includes Markus Armbruster
2022-12-08 15:03 ` Stefan Hajnoczi [this message]
2022-12-08 14:23 ` [PATCH 3/4] coroutine: Clean up superfluous inclusion of qemu/lockable.h Markus Armbruster
2022-12-08 15:05 ` Stefan Hajnoczi
2022-12-08 14:23 ` [PATCH 4/4] coroutine: Break inclusion loop Markus Armbruster
2022-12-08 15:07 ` Stefan Hajnoczi
[not found] ` <2ac0daae-da25-0a31-9a73-8f186cc510e9@redhat.com>
2022-12-13 0:34 ` Paolo Bonzini
2022-12-15 6:49 ` Markus Armbruster
2022-12-17 12:42 ` Paolo Bonzini
2022-12-19 4:23 ` Markus Armbruster
2022-12-17 17:23 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QWfZ11aoMEGH3NXa2bNi9K9xLxKPF_aJ0isSejiq2UAvg@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).