From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SufPa-0001yg-0r for qemu-devel@nongnu.org; Fri, 27 Jul 2012 03:56:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SufPU-0001nS-1Z for qemu-devel@nongnu.org; Fri, 27 Jul 2012 03:56:37 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:43078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SufPT-0001nJ-Pf for qemu-devel@nongnu.org; Fri, 27 Jul 2012 03:56:31 -0400 Received: by lbok6 with SMTP id k6so1960195lbo.4 for ; Fri, 27 Jul 2012 00:56:30 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <501145F7.6010705@redhat.com> References: <1343218884-14980-1-git-send-email-stefanha@linux.vnet.ibm.com> <1343218884-14980-8-git-send-email-stefanha@linux.vnet.ibm.com> <501145F7.6010705@redhat.com> Date: Fri, 27 Jul 2012 08:56:30 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [PATCH v2 7/7] qemu-iotests: add 039 qcow2 lazy refcounts test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Khoa Huynh , Anthony Liguori , Stefan Hajnoczi , qemu-devel@nongnu.org On Thu, Jul 26, 2012 at 2:28 PM, Kevin Wolf wrote: > Am 25.07.2012 14:21, schrieb Stefan Hajnoczi: >> This tests establishes the basic post-conditions of the qcow2 lazy >> refcounts features: >> >> 1. If the image was closed normally, it is marked clean. >> >> 2. If an allocating write was performed and the image was not close >> normally, then it is marked dirty. >> >> a. Written data can be read back successfully. >> b. The image file can be repaired and will be marked clean again. >> >> Signed-off-by: Stefan Hajnoczi > > I think an important case that is missing here is opening a dirty image > rw without having run qemu-img check -r first. I have added that test case. >> +== Read-only access must still work == >> +read 512/512 bytes at offset 0 >> +512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) >> +incompatible_features 0x1 >> + >> +== Repairing the image file must succeed == >> +ERROR OFLAG_COPIED: offset=8000000000050000 refcount=0 >> +Repairing cluster 5 refcount=0 reference=1 >> +No errors were found on the image. >> +incompatible_features 0x0 > > I wonder what happened to the "The following inconsistencies were found > and repaired" message. Most likely not a problem with qemu-iotests, > though, but something unexpected in qemu-img. It's because opening a qcow2 image read/write when the dirty flag is set causes a repair. This accounts for the "Repairing cluster 5 ..." message. Then qemu-img check -r all calls bdrv_check() on an already repaired image file and we get the "No errors were found on the image". Stefan