From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42320)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W9KuJ-0003V0-7b
	for qemu-devel@nongnu.org; Fri, 31 Jan 2014 15:41:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W9KuI-00015m-91
	for qemu-devel@nongnu.org; Fri, 31 Jan 2014 15:41:47 -0500
Received: from mail-oa0-x22c.google.com ([2607:f8b0:4003:c02::22c]:39258)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W9KuI-00015i-1S
	for qemu-devel@nongnu.org; Fri, 31 Jan 2014 15:41:46 -0500
Received: by mail-oa0-f44.google.com with SMTP id g12so5792326oah.3
	for <qemu-devel@nongnu.org>; Fri, 31 Jan 2014 12:41:45 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <31A541D2-8EEA-419E-BCFE-995641A78866@kamp.de>
References: <1391168333-11436-1-git-send-email-pl@kamp.de>
	<20140131160720.GC15009@stefanha-thinkpad.redhat.com>
	<31A541D2-8EEA-419E-BCFE-995641A78866@kamp.de>
Date: Fri, 31 Jan 2014 21:41:44 +0100
Message-ID: <CAJSP0QWk7J0XH5CxSB2ev4VR8YhBLJ-3KD+uPCXHivZGyLtmaA@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCHv8 0/5] block: add native support for NFS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: Kevin Wolf <kwolf@redhat.com>, =?ISO-8859-1?Q?Beno=EEt_Canet?= <benoit.canet@irqsave.net>, Fam Zheng <famz@redhat.com>, ronnie sahlberg <ronniesahlberg@gmail.com>, Jeff Cody <jcody@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>, Orit Wasserman <owasserm@redhat.com>, Federico Simoncelli <fsimonce@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Wenchao Xia <xiawenc@linux.vnet.ibm.com>

On Fri, Jan 31, 2014 at 6:32 PM, Peter Lieven <pl@kamp.de> wrote:
>
> Am 31.01.2014 um 17:07 schrieb Stefan Hajnoczi <stefanha@redhat.com>:
>
>> On Fri, Jan 31, 2014 at 12:38:48PM +0100, Peter Lieven wrote:
>>> This adds v6 of the NFS protocol driver + qemu-iotest adjustments.
>>>
>>> v7->v8:
>>> - bump libnfs requirement to 1.9.2
>>> - renamed NFSRPC->status to NFSRPC->ret [Benoit]
>>> - avoid double invocation of nfs_client_close in nfs_file_create [Benoit]
>>> - fixed error propagation in nfs_file_open [Benoit]
>>
>> I was able to create a qcow2 image and boot a VM successfully over NFS.
>
> This test is obviously new. It is not suitable for protocols other than file as it seems (as a lot
> of other tests). The file not found error looks like it and not a problem with the driver itself.
> I think it needs to be adjusted to work with file only for now.

I think you are right.  Max is the author of the tests, he can confirm
that the -o file.file.filename= syntax he used and the blkverify
driver only support the file protocol for now.

Peter: Please send another revision that restricts protocol to 'file'
for these tests.  It can be part of the patch that adjusts the other
test cases.

Stefan