Re: [PATCH v4 0/2] HP-PARISC: LASI's NCR710 SCSI Controller

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]

On Sun, Nov 9, 2025, 17:08 Helge Deller <deller@gmx.de> wrote:

> On 11/9/25 21:57, Stefan Hajnoczi wrote:
> > On Mon, Nov 3, 2025 at 1:40 PM Soumyajyotii Ssarkar
> > <soumyajyotisarkar23@gmail.com> wrote:
> >>
> >> Fixing Defects reported by Coverity Scan for NCR710 SCSI Controller in
> QEMU.
> >> QEMU runs the Coverity static analyzer to identify potential bugs in
> >> code that has recently been merged.
> >>
> >> In view of the above these issues came to light.
> >> I would request you to please review the fixes for the same.
> >>
> >> Reported by: Stefan Hajnoczi <stefanha@gmail.com>
> >> and GuoHan Zhao <zhaoguohan@kylinos.cn>
> >>
> >> Soumyajyotii Ssarkar (2):
> >>    hw/scsi/ncr53c710.c: Fixing null pointer dereference issue.
> >>    hw/scsi/ncr53c710.c: Fixing Incorrect expression
> (IDENTICAL_BRANCHES)
> >>
> >>   hw/scsi/ncr53c710.c | 8 +-------
> >>   1 file changed, 1 insertion(+), 7 deletions(-)
> >
> > I am not familiar with the device being emulated, so I have only
> > reviewed this for C issues:
> >
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Thanks!
> Btw, I just sent out a pull request which includes those patches.
> (but in it I missed your Reviewed-by)
>

Great! No worries about missing my R-b.

Stefan


> Helge
>

[-- Attachment #2: Type: text/html, Size: 2465 bytes --]