From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu block <qemu-block@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>,
Julia Suvorova <jusual@mail.ru>,
Aarushi Mehta <mehta.aaru20@gmail.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block/io_uring: use pkg-config for liburing
Date: Sat, 25 May 2019 10:15:31 +0100 [thread overview]
Message-ID: <CAJSP0QWo-JK1CW4tuwugxXDyuTbov0y_Tjs9S068beufVMQxeQ@mail.gmail.com> (raw)
In-Reply-To: <20190525090559.31914-1-stefanha@redhat.com>
On Sat, May 25, 2019 at 10:07 AM Stefan Hajnoczi <stefanha@redhat.com> wrote:
Based-on: <20190524140337.13415-1-mehta.aaru20@gmail.com>
"[RFC PATCH v2 0/9] Add support for io_uring"
> diff --git a/block/Makefile.objs b/block/Makefile.objs
> index 262d413c6d..eed8043740 100644
> --- a/block/Makefile.objs
> +++ b/block/Makefile.objs
> @@ -62,6 +62,7 @@ block-obj-$(if $(CONFIG_LZFSE),m,n) += dmg-lzfse.o
> dmg-lzfse.o-libs := $(LZFSE_LIBS)
> qcow.o-libs := -lz
> linux-aio.o-libs := -laio
> -io_uring.o-libs := -luring
> +io_uring.o-flags := $(LINUX_IO_URING_CFLAGS)
Oops, this should be -cflags instead of -flags. The current
liburing.pc file doesn't define any special cflags so I didn't notice
this problem.
Please fix this up when integrating this into your patch series, thanks!
next prev parent reply other threads:[~2019-05-25 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 9:05 [Qemu-devel] [PATCH] block/io_uring: use pkg-config for liburing Stefan Hajnoczi
2019-05-25 9:15 ` Stefan Hajnoczi [this message]
2019-06-05 15:56 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QWo-JK1CW4tuwugxXDyuTbov0y_Tjs9S068beufVMQxeQ@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=jusual@mail.ru \
--cc=kwolf@redhat.com \
--cc=mehta.aaru20@gmail.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).