From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38666)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ScwU8-0001iH-5x
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:32:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ScwU6-00054p-JR
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:32:03 -0400
Received: from mail-bk0-f45.google.com ([209.85.214.45]:50870)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ScwU6-00054U-A0
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:32:02 -0400
Received: by bkwj10 with SMTP id j10so1721026bkw.4
	for <qemu-devel@nongnu.org>; Fri, 08 Jun 2012 03:31:59 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1339080860-16036-1-git-send-email-zwu.kernel@gmail.com>
References: <1339080860-16036-1-git-send-email-zwu.kernel@gmail.com>
Date: Fri, 8 Jun 2012 11:31:21 +0100
Message-ID: <CAJSP0QWvr+P=H-3KZ3imt+SRzeOhNFnwJ68-g8U3R86OC6Zgug@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 2/2] net: add the support for -netdev
 socket, listen
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: zwu.kernel@gmail.com
Cc: pbonzini@redhat.com, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On Thu, Jun 7, 2012 at 3:54 PM,  <zwu.kernel@gmail.com> wrote:
> @@ -86,7 +82,16 @@ static void net_socket_send(void *opaque)
> =A0 =A0 =A0 =A0 /* end of connection */
> =A0 =A0 eoc:
> =A0 =A0 =A0 =A0 qemu_set_fd_handler(s->fd, NULL, NULL, NULL);
> + =A0 =A0 =A0 =A0qemu_set_fd_handler(s->listen_fd, net_socket_accept, NUL=
L, s);

What happens when this is not a listen socket?  I suggest setting
listen_fd to -1 during creation and not calling qemu_set_fd_handler()
when listen_fd is -1 here.  If listen_fd is 0 then we'll register
net_socket_accept when standard input becomes ready!

> =A0 =A0 =A0 =A0 closesocket(s->fd);
> +
> + =A0 =A0 =A0 =A0s->fd =3D 0;

-1 should be used since 0 is a valid file descriptor (standard input).

Stefan