From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46679)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RvpnD-0006z2-Fq
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 07:41:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Rvpn6-0004Zu-4A
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 07:41:35 -0500
Received: from mail-lpp01m020-f173.google.com ([209.85.217.173]:45931)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Rvpn5-0004Zb-RM
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 07:41:27 -0500
Received: by lbbgf7 with SMTP id gf7so1435747lbb.4
	for <qemu-devel@nongnu.org>; Fri, 10 Feb 2012 04:41:26 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1326731457-9056-12-git-send-email-pbonzini@redhat.com>
References: <1326731457-9056-1-git-send-email-pbonzini@redhat.com>
	<1326731457-9056-12-git-send-email-pbonzini@redhat.com>
Date: Fri, 10 Feb 2012 12:41:25 +0000
Message-ID: <CAJSP0QX-t7Jy-oijnqNv5-RmwicMBmKEYmVFYrehbLHZR+TAsw@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 11/15] virtio-scsi: Add virtio-scsi stub
	device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

On Mon, Jan 16, 2012 at 4:30 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> +static void virtio_scsi_get_config(VirtIODevice *vdev,
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 uin=
t8_t *config)
> +{
> + =A0 =A0VirtIOSCSIConfig *scsiconf =3D (VirtIOSCSIConfig *)config;
> + =A0 =A0VirtIOSCSI *s =3D (VirtIOSCSI *)vdev;
> +
> + =A0 =A0stl_raw(&scsiconf->num_queues, s->conf->num_queues);
> + =A0 =A0stl_raw(&scsiconf->seg_max, 128 - 2);
> + =A0 =A0stl_raw(&scsiconf->max_sectors, s->conf->max_sectors);
> + =A0 =A0stl_raw(&scsiconf->cmd_per_lun, s->conf->cmd_per_lun);
> + =A0 =A0stl_raw(&scsiconf->event_info_size, sizeof(VirtIOSCSIEvent));
> + =A0 =A0stl_raw(&scsiconf->sense_size, s->sense_size);
> + =A0 =A0stl_raw(&scsiconf->cdb_size, s->cdb_size);
> + =A0 =A0stl_raw(&scsiconf->max_channel, VIRTIO_SCSI_MAX_CHANNEL);
> + =A0 =A0stl_raw(&scsiconf->max_target, VIRTIO_SCSI_MAX_TARGET);
> + =A0 =A0stl_raw(&scsiconf->max_lun, VIRTIO_SCSI_MAX_LUN);

At this early stage we still have the option of designing the device
to be little- or big-endian.  I'm in favour of a fixed endianness even
though existing virtio devices tend to use guest-endian.

What do you think?

Stefan