From: Stefan Hajnoczi <stefanha@gmail.com>
To: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 1/2] i_generation / st_gen support for local fs type
Date: Thu, 4 Aug 2011 11:17:04 +0100 [thread overview]
Message-ID: <CAJSP0QX61V76amXo=k9M3fEx=bOfS3mbvQLcZPJKtr3HWjJLmQ@mail.gmail.com> (raw)
In-Reply-To: <1312452371-10375-2-git-send-email-harsh@linux.vnet.ibm.com>
On Thu, Aug 4, 2011 at 11:06 AM, Harsh Prateek Bora
<harsh@linux.vnet.ibm.com> wrote:
> +static int local_ioc_getversion(FsContext *ctx, V9fsPath *path, uint64_t *st_gen)
> +{
> + int mode = 0600;
> + int fd;
> +
> + fd = local_open(ctx, path, mode);
> + if(fd < 0) {
> + return fd;
> + }
> + return ioctl(fd, FS_IOC_GETVERSION, st_gen);
fd is leaked.
Stefan
next prev parent reply other threads:[~2011-08-04 10:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 10:06 [Qemu-devel] [PATCH 0/2] Support for i_generation / st_gen in 9p server Harsh Prateek Bora
2011-08-04 10:06 ` [Qemu-devel] [PATCH 1/2] i_generation / st_gen support for local fs type Harsh Prateek Bora
2011-08-04 10:17 ` Stefan Hajnoczi [this message]
2011-08-04 10:06 ` [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver Harsh Prateek Bora
2011-08-04 10:21 ` Stefan Hajnoczi
2011-08-04 11:20 ` Aneesh Kumar K.V
2011-08-04 11:47 ` Stefan Hajnoczi
2011-08-04 12:03 ` Aneesh Kumar K.V
2011-08-04 14:31 ` Stefan Hajnoczi
2011-08-04 18:45 ` Aneesh Kumar K.V
2011-08-04 21:57 ` Stefan Hajnoczi
2011-08-05 6:40 ` Aneesh Kumar K.V
2011-08-05 9:24 ` Stefan Hajnoczi
2011-08-05 11:32 ` Aneesh Kumar K.V
2011-08-05 12:53 ` Stefan Hajnoczi
2011-08-10 15:17 ` Stefan Hajnoczi
2011-08-10 15:17 ` Stefan Hajnoczi
2011-08-10 17:33 ` Aneesh Kumar K.V
2011-08-11 7:16 ` Harsh Bora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJSP0QX61V76amXo=k9M3fEx=bOfS3mbvQLcZPJKtr3HWjJLmQ@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=harsh@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).