From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: Fix offset in qcow2_read_extensions
Date: Tue, 28 Feb 2012 09:32:14 +0000 [thread overview]
Message-ID: <CAJSP0QXFLxizwLmk+w6x=kFsGKB3zcB7=YJPxHGyaN7mWeYukQ@mail.gmail.com> (raw)
In-Reply-To: <1330360045-27198-1-git-send-email-kwolf@redhat.com>
On Mon, Feb 27, 2012 at 4:27 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> The spec says that the length of extensions is padded to 8 bytes, not
> the offset. Currently this is the same because the header size is a
> multiple of 8, so this is only about compatibility with future changes
> to the header size.
>
> While touching it, move the calculation to a common place instead of
> duplicating it for each header extension type.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
prev parent reply other threads:[~2012-02-28 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 16:27 [Qemu-devel] [PATCH] qcow2: Fix offset in qcow2_read_extensions Kevin Wolf
2012-02-28 9:32 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJSP0QXFLxizwLmk+w6x=kFsGKB3zcB7=YJPxHGyaN7mWeYukQ@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).