From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuJxx-0005c0-FY for qemu-devel@nongnu.org; Fri, 28 Nov 2014 06:44:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XuJxw-00043n-GI for qemu-devel@nongnu.org; Fri, 28 Nov 2014 06:44:01 -0500 Received: from mail-ob0-x231.google.com ([2607:f8b0:4003:c01::231]:40629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuJxw-00043d-C4 for qemu-devel@nongnu.org; Fri, 28 Nov 2014 06:44:00 -0500 Received: by mail-ob0-f177.google.com with SMTP id va2so4841476obc.22 for ; Fri, 28 Nov 2014 03:43:59 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1417158306.3268.3@smtp.corp.redhat.com> References: <1417105946-27374-1-git-send-email-mst@redhat.com> <20141127211304.GA26295@redhat.com> <20141128011646.GA27676@fam-t430.nay.redhat.com> <1417158306.3268.3@smtp.corp.redhat.com> Date: Fri, 28 Nov 2014 11:43:59 +0000 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH RFC for-2.2] virtio-blk: force 1st s/g to match header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: Kevin Wolf , Peter Maydell , Fam Zheng , "Michael S. Tsirkin" , qemu-devel , =?UTF-8?Q?Marc_Mar=C3=AD?= , Stefan Hajnoczi On Fri, Nov 28, 2014 at 7:05 AM, Jason Wang wrote: > > > On Fri, Nov 28, 2014 at 9:16 AM, Fam Zheng wrote: >> >> On Thu, 11/27 23:13, Michael S. Tsirkin wrote: >>> >>> On Thu, Nov 27, 2014 at 07:21:35PM +0000, Stefan Hajnoczi wrote: >>> > On Thu, Nov 27, 2014 at 4:33 PM, Michael S. Tsirkin >>> wrote: >>> > > We leak cpu mappings when 1st s/g is not exactly the >>> > > header. As we don't set ANY_LAYOUT, we can at this point >>> > > simply assert the correct length. >>> > > >>> > > This will have to be fixed once ANY_LAYOUT is set. >>> > > >>> > > Signed-off-by: Michael S. Tsirkin >>> > > --- >>> > > >>> > > Untested: posting for early feedback. >>> > > Reviewed-by: Stefan Hajnoczi >>> Stefan, you are going to merge this for 2.2? >>> Peter, if Stefan is merging this one, we can >>> take Jason's patch for -net and that should be >>> enough for 2.2. >> >> >> My test bot saw a failure of "make check": >> >> qemu-system-x86_64: virtio-blk request outhdr too long >> Broken pipe >> GTester: last random seed: R02S44c5a09d74c0603f0091ed20d1395121 >> qemu-system-x86_64: virtio-blk request outhdr too long >> Broken pipe >> GTester: last random seed: R02Sfdf270c8e1ed75c1f2047e3f0fb89b88 >> qemu-system-x86_64: virtio-blk request outhdr too long >> Broken pipe >> GTester: last random seed: R02Sd292c540929b963ed9d7d155f3db5452 >> qemu-system-x86_64: virtio-blk request outhdr too long >> Broken pipe >> GTester: last random seed: R02Sfc775a34a844c39f376aa478eda7573f >> [vmxnet3][WR][vmxnet3_peer_has_vnet_hdr]: Peer has no virtio extension. >> Task offloads will be emulated. >> make: *** [check-qtest-x86_64] Error 1 >> >> Fam > > > This probably because of the test itself. > > But anyway all kinds of guests (especially Windows drivers) need to be > tested. Right, the test case explicitly tests different descriptor layouts, even though virtio-blk-pci does not set the ANY_LAYOUT feature bit. Either the test case needs to check ANY_LAYOUT before using the 2-descriptor layout or it needs to expect QEMU to refuse (in this case exit(1), which is not very graceful). The quick fix is to skip the 2-descriptor layout tests and re-enable them once virtio-blk actually supports ANY_LAYOUT. Any objections? Stefan